Dataplanes tags error fix #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 3, 2020 09:58
…y. it was throwing an error when the number of tags was more than the amount of colors available in the array.
|
@jakubdyszkiewicz can you review when you have a chance? I would like to get a new version compiled. |
jakubdyszkiewicz
approved these changes
Mar 10, 2020
|
Can we merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was caused when the number of tags exceeded the number of colors available in an array for the tags. The tags were originally going to be different colors but instead were simplified to one color. I've removed the unused code and simplified the tag handling in
DataOverviewand this fixes the error seen here.I admittedly overlooked this because none of my test DPs had more than 8 tags.
Now we can have more than 8 tags with no errors: screenshot.