Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mesh Wizard and UI overhaul #17

Merged
merged 78 commits into from
Apr 17, 2020
Merged

Mesh Wizard and UI overhaul #17

merged 78 commits into from
Apr 17, 2020

Conversation

bloqhead
Copy link
Contributor

To access the Wizard, after launching the GUI, go to the Meshes or Overview pages via the sidebar. You can not proceed in the Wizard unless you fill in a mesh name.

If you switch to "All Meshes" in the sidebar pulldown, each view will toggle between showing Policies and data for all collective Meshes, or for the specific Mesh you select.

Todo

  • Create the next wizard for Dataplanes. This is an undertaking and is essentially 2 different wizards because of the conditionals involved. My recommendation is that we let users test the Mesh wizard first so that we can see how they like the Wizard framework, and then we can iterate on adding more wizard flows.
  • Refactor the YamlView component on all of the tabbed view pages so that it accepts both Kubernetes and Universal code formats (similar to what is displayed when completing the Mesh wizard). Currently, putting a tabbed component inside of a tabbed component breaks both components and causes unintended behaviors
  • When the Mesh scanner is complete at the end of the Mesh wizard, you'll notice that there is a 1 second discrepancy between the content above the scanner component hiding, and the scanner component completing. This is because the scanner component is finishing its 1 second interval before stopping the animation and displaying the success message. This is non-breaking and cosmetic.

Notes

I've disabled mocking in development mode so that when you test this locally, you can use actual Kuma data, vs. mocked data.

Daryn St. Pierre added 30 commits February 28, 2020 17:57
… of the Global Overview additions and revisions. added some more mocks for testing.
…mponent. added more mocking to test more thoroughly.
… it will become the Global Overview. streamlined the VueX store. added more mocks for testing. improvements to the CardSkeleton component.
…tes added for handling the total count of all entities. Overview revisions for the CardSkeleton component.
…umbs. mock adjustments to test the new offline dataplane table. offline dataplane table functionality added.
…up for it, as well as testing with dynamic content.
…nager are doing. reduced table cell padding on the DataOverview component.
…t we can pass the data to the Tabs component accordingly. Tabs component updates and style revisions.
… for the table view. initial new scaffolding for the HealthChecks page.
…esh not saving to localStorage. added more mocks.
…he HealthChecks page. improved the DataOverview component. created a new helper for grabbing only the desired key value pairs from an object. improved the Tabs component.
… to CSS variables for more centralized control and consistency. Tabs and DataOverview component style revisions and additions.
…me colors to the variables. DataOverview table component style revisions to accommodate properly for pagination.
…w be set from within sibling components using VueX state, a new action, and a new mutation.
…ent for encapsulating multiple components. Pagination style revisions.
…nction written that leverages vuex and some magic CSS.
Daryn St. Pierre added 23 commits April 6, 2020 15:42
…t. improved the way the default selected mesh value is determined in the App component upon initial load.
…the app before the user gets started using it.
… Array. makes it much more useful. the Dataplanes overview is now using the new tabbed view. updated the shortcut card and CTA on the Overview component so that the Mesh one links to the appropriate Mesh wizard.
…or the Wizard form data so that it can carry through easier to the code block output functionality. improved the updateStorage mixin to be generally more useful and emit more data. added code building functionality and Mesh schema to the Mesh Wizard..
…sfully into Kuma. improved the Tabs component functionality to allow an override that determines which tab is selected upon initial load, instead of relying on VueX state.
…d Path are interchangeable and need to be switched out conditionally in the schema.
…proach and is problematic in some browsers. the introduction of a revised KTable component for Kongponents will address this but the release date on that is not yet determined. fixed the endpoint fetching for the Dataplanes view paired with the new table view.
…arrangement to closer match the new mockups, but still working on some of the views, so it's not finalized. style revisions for LabelList, DataOverview tables, and YAML view.
…ponent that will most likely replace the YAMLView component. created a mixin for handling code formatting and output for the kumactl CLI. functionality revisions for the final Mesh Wizard step. small revisions to various components.
…or handling CLI command formatting and output for kumactl. revisions to the DataOverview components. various fixes and style revisions.
…mal styling otherwise for readability. simplified the completion step for the Mesh Wizard. small style override for the KEmptyState component inside of the Scanner component. meshes commented out in the mocks so that we can demo it with real Kuma API data for this particular instance.
…out from the Refresh button. revised the Scanner component to be more simplified and less redundant. changed all placeholders to entered values on the Mesh wizard form fields where appropriate.
…dpoints. revised each view to handle both All and Mesh-specific filtering via the sidebar Mesh selector. general clean up and renaming for clarity and consistency. even more mocks for testing. revised all entity and policy counter actions in the VueX store to use the new endpoints.
… and route adjustments to clean and tighten things up. GlobalOverview adjustments to account for Mesh Wizard being the only present one.
…perly with individual and all items. added simple validation for the Mesh name on the Mesh wizard.
@bloqhead bloqhead requested a review from a team April 16, 2020 23:27
Daryn St. Pierre added 3 commits April 17, 2020 09:54
… that it goes to the Meshes page and loads in the mesh data we want.
…hes page. it will send them to the Mesh child route and default to showing all meshes.
@bloqhead bloqhead merged commit f21809d into master Apr 17, 2020
@bloqhead bloqhead deleted the feat/wizard-framework branch April 17, 2020 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant