Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataplane Wizard #20

Merged
merged 39 commits into from
May 12, 2020
Merged

Dataplane Wizard #20

merged 39 commits into from
May 12, 2020

Conversation

bloqhead
Copy link
Contributor

@bloqhead bloqhead commented Apr 21, 2020

This is the first of 2 stages for the Dataplane Wizard. The first stage being the Kubernetes flow, and the second being Universal.

Here is a quick video recording of it in action

To test it:

  1. Start up the GUI: yarn install (if you haven't already), and yarn serve
  2. For Kubernetes: http://localhost:8080/#/wizard/kubernetes-dataplane / For Universal: http://localhost:8080/#/wizard/universal-dataplane
  3. Go through the form and test each option available to see conditional handling and display

Notes:

  • The last step does not yet display code for creating a Dataplane. That part is still in progress.
  • You will see a panel at the start of this wizard that will detect what environment Kuma is running in, and provide instructions to view the other environment's wizard.
  • You'll see a "Debugger" panel in the right sidebar. As noted in the component itself, this is only displayed when running the GUI in development mode. The app runs in dev mode when using yarn serve in this repo, but runs in production mode when compiled and running from within Kuma. This panel exists simply to keep track of v-model data that will be used to assemble the code output.

Daryn St. Pierre added 6 commits April 20, 2020 12:52
…e Wizard after. added names to each view component for consistency.
…added but still needs to be wired up accordingly for conditionals, storing data, etc.
…step in the wizard. added more functionality to the FormFragment component to fit the needs of the Dataplane wizard. split the routes for Kubernetes and Universal wizards since they're entirely separate.
…aces, Ingress, etc. added a visual debugger for seeing changes from each field's v-model data.
@bloqhead bloqhead requested a review from a team April 21, 2020 20:33
@bloqhead bloqhead marked this pull request as draft April 21, 2020 20:48
Daryn St. Pierre added 19 commits April 22, 2020 09:55
…evised the function for handling CLI Kuma output so that it has more flexibility with the command itself. small improvement to the sidebar debugger box.
…he last step only displays the needed tab (Kubernetes). the Universal tab is not needed on this specific wizard since it's specific to Kubernetes.
…asier reuse. removed all individual localStorage field functions in favor of a singular watcher that pushes the entire form data array via v-model data.
…rings and an auto-generated ID name based on the Service name.
…r both Gateway and Service Dataplane modes.
…meshes for both the count on the Global Overview, and getting the list of meshes for the pulldown.
…he Dataplanes view for creating a new Dataplane via the wizard. fixed a YAML structure nesting error for tags in the Universal Dataplane schema.
@bloqhead
Copy link
Contributor Author

bloqhead commented May 7, 2020

@subnetmarco I've finished the Universal Dataplane wizard but am stuck on what we should include for code in the last step where the user starts their new Dataplane. I am able to successfully create both Service and Gateway Dataplanes from the Wizard.

To test the Universal DP wizard:

  1. yarn serve to run the app
  2. Go to http://localhost:8080/#/wizard/universal-dataplane
  3. Follow the steps provided

In the last step I'm currently including this code to start the Dataplane:

kuma-dp run \
  --name=your-dataplane-id \
  --mesh=your-mesh \
  --cp-address=http://localhost:5681`

But I'm required to create a dataplane-token first, so I am referencing the Dataplane Token section in the docs. I don't have a token server or anything running at http://localhost:5679/tokens though, so I'm not sure what to do. Please advise.

Daryn St. Pierre added 6 commits May 8, 2020 15:59
…he wizards. it now stops running in instances where the user might leave the page or go backwards in the wizard steps to change something.
… this will sometimes have some information we may leverage in the GUI.
…ut for starting the Dataplane in the Universal wizard.
…of the Kubernetes wizard that are not applicable until we have endpoints for fetching Kubernetes namespace information.
… to instead give the user links to the new wizards based on environment, as well as offer a way to skip to the Dashboard.
@bloqhead bloqhead marked this pull request as ready for review May 12, 2020 14:46
Daryn St. Pierre added 6 commits May 12, 2020 13:46
…ment and the current wizard into consideration in order to display the appropriate message and controls. made the Namespace field required before moving forward on the Kubernetes wizard.
…Universal DP wizard. removed all placeholders from fields to reduce confusion.
@bloqhead bloqhead merged commit 063c3cc into master May 12, 2020
@bloqhead bloqhead deleted the feat/dataplane-wizard branch May 18, 2020 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant