feat(dataplanes): add visualization for built-in gateways #2082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kuma-gui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
kleinfreund
changed the title
kleinfreund
commented
Jan 25, 2024
johncowen
reviewed
Jan 25, 2024
Handle built-in gateways in the new Dataplane detail view display. Changes the Dataplane stats data source to expect a `service` parameter to account for that part being dynamic in the case of gateways and provides `'localhost_'` for standard proxies as the value for this parameter. This allows us to maintain one data source definition for stats. Signed-off-by: Philipp Rudloff <philipp.rudloff@konghq.com>
kleinfreund
commented
Feb 6, 2024
johncowen
approved these changes
Feb 6, 2024
kleinfreund
deleted the
feat/support-dataplane-visualization-for-built-in-gateways
branch
johncowen
added a commit
that referenced
this pull request
Feb 13, 2024
Various amends for the Dataplane Gateway Viz - Adds an `inboundName` and `inbound[].name` properties at the data layer level (see #2082 (comment)) - Fills in a single inbound for built-in gateways based on inferring the data from the tags of the gateway, again in the data layer. This is only temporary, gateways can have multiple inbounds. - Using the above, removes the duplication/fork in `DataPlaneDetailView` for showing the Traffic components. This also has the benefit that all the empty/loading/error states work the same as the view when we are viewing a sidecar/standard dataplane. - Replaces the hardcoded `HTTP` protocol for the current single gateway inbound with the correct protocol from the stats endpoint. - Replaces instances of a `Cluster` 'protocol' with `tcp` for gateway outbounds. Whilst this is hardcoded to `tcp` for gateway outbounds only, I figure its better than showing `Cluster` for a protocol. Figuring out the protocol for gateway outbounds is going to be a little more involved using the `listeners` property of the `/stats` endpoint. - I hid our filled out gateway inbounds from anywhere else we show inbounds for the moment at least, using DataCollection to do that in places, although I'm guessing that if a gateway has inbounds then we should also show them in other places (we currently don't) All in all while we still don't show multiple inbounds if there are any, and the protocol for the outbounds could be wrong. I figured there was enough improvement here (no duplication, better states, no `Cluster` protocol etc) to PR something and continue with these issues. Signed-off-by: John Cowen <john.cowen@konghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle built-in gateways in the new Dataplane detail view display.
Changes the Dataplane stats data source to expect a
serviceparameter to account for that part being dynamic in the case of gateways and provides'localhost_'for standard proxies as the value for this parameter. This allows us to maintain one data source definition for stats.Resolves #2049.
Signed-off-by: Philipp Rudloff philipp.rudloff@konghq.com