Switch the count in each VueX method for getting entity totals #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the new total field in the HTTP API endpoints. also set each request to only get 1 item for the size parameter so that we are not needlessly getting a list of items on each call. this makes each request significantly smaller.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch should be used in conjunction with #723 in the Kuma repo.
This change updates each total count method in the VueX actions to use the
totalparameter from the HTTP API. Each request is also modified to only use asizeparameter of1so that we are not also needlessly fetching a list of entities when we only need the total. This helps reduce API request sizes.Running Kuma in Universal mode with 20,000 Meshes:
(the above was tested in Firefox)