chore: moves several components to our x namespace #3088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kuma-gui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
johncowen
force-pushed
the
chore/k-to-x-pt1
branch
5 times, most recently
from
d249dfe
to
a8b2b35
Compare
Signed-off-by: John Cowen <john.cowen@konghq.com>
johncowen
force-pushed
the
chore/k-to-x-pt1
branch
from
a8b2b35
to
a3a624f
Compare
slonka
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have various reasons to wrap, fix or otherwise rename some KComponents. This means that in order to know whether to use a
XorKcomponent, you need to know whether some sort of extra functionality/fixing/wrapping is required.It would be much easier if all our generic GUI components were prefixed with
X(we don't want to useKbecause we don't own that prefix)This PR does several renames:
One of the consequences of moving CodeBlock to
xis that thecode-blockfolder also contained an additional componentResourceCodeBlock. I have a long running task of reducing the amount of CodeBlock components we have (I think we had 4 or 5 at one point), and at some point soon I plan on merging thisResourceCodeBlockintoXCodeBlockmeaning we will only have 1 CodeBlock component in our application.Lastly, there are still some outstanding
Kcomponents that need a rename of a wrap, but I didn't want to do too much in a single PR.