Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history 
Signed-off-by: Krzysztof Słonka <slonka@users.noreply.github.com>
  • Loading branch information
@slonka
slonka authored Nov 7, 2023
1 parent 45e381b commit 50103a0
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions app/_src/production/upgrades-tuning/fine-tuning.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ Follow the {% if_version lte:2.1.x %}[transparent proxying](/docs/{{ page.versio

Starting with release 2.5 the problem stated in [reachable services](#reachable-services) section
can be also mitigated by defining [MeshTrafficPermissions](/docs/{{ page.version }}/policies/meshtrafficpermission) in combination with:

Check warning on line 30 in app/_src/production/upgrades-tuning/fine-tuning.md

View workflow job for this annotation

GitHub Actions / Lint docs 

[vale] reported by reviewdog 🐶
[Google.Parens] Use parentheses judiciously.

Raw Output:
{"message": "[Google.Parens] Use parentheses judiciously.", "location": {"path": "app/_src/production/upgrades-tuning/fine-tuning.md", "range": {"start": {"line": 30, "column": 59}}}, "severity": "INFO"}
- `KUMA_EXPERIMENTAL_AUTO_REACHABLE_SERVICES=true` environment variable set on **global CP** (for helm use `--set {{site.set_flag_values_prefix}}controlPlane.envVars.KUMA_EXPERIMENTAL_AUTO_REACHABLE_SERVICES=true`) and
- `KUMA_EXPERIMENTAL_AUTO_REACHABLE_SERVICES=true` environment variable set on **zone CP** (for helm use `--set {{site.set_flag_values_prefix}}controlPlane.envVars.KUMA_EXPERIMENTAL_AUTO_REACHABLE_SERVICES=true`) and

Check warning on line 31 in app/_src/production/upgrades-tuning/fine-tuning.md

View workflow job for this annotation

GitHub Actions / Lint docs 

[vale] reported by reviewdog 🐶
[Google.Parens] Use parentheses judiciously.

Raw Output:
{"message": "[Google.Parens] Use parentheses judiciously.", "location": {"path": "app/_src/production/upgrades-tuning/fine-tuning.md", "range": {"start": {"line": 31, "column": 1}}}, "severity": "INFO"}
- [mTLS enabled in strict mode](/docs/{{ page.version }}/policies/mutual-tls/)

Switching on the flag will result in computing a graph of dependencies between the services

Check warning on line 34 in app/_src/production/upgrades-tuning/fine-tuning.md

View workflow job for this annotation

GitHub Actions / Lint docs 

[vale] reported by reviewdog 🐶
[Google.Will] Avoid using 'will'.

Raw Output:
{"message": "[Google.Will] Avoid using 'will'.", "location": {"path": "app/_src/production/upgrades-tuning/fine-tuning.md", "range": {"start": {"line": 34, "column": 23}}}, "severity": "WARNING"}
Expand Down Expand Up @@ -68,12 +68,12 @@ Sections below highlight the most important aspects of this feature, if you want

The following kinds affect the graph generation and performance:
- all levels of `MeshService`
- [top](/docs/{{ page.version }}/policies/targetref/#target-resources) level `MeshSubset` and `MeshServiceSubset` with `k8s.kuma.io/namespace`, `k8s.kuma.io/service`, `k8s.kuma.io/port` labels
- [top](/docs/{{ page.version }}/policies/targetref/#target-resources) level `MeshSubset` and `MeshServiceSubset` with `k8s.kuma.io/namespace`, `k8s.kuma.io/service`, `k8s.kuma.io/port` tags

Check failure on line 71 in app/_src/production/upgrades-tuning/fine-tuning.md

View workflow job for this annotation

GitHub Actions / Lint docs 

[vale] reported by reviewdog 🐶
[Vale.Terms] Use 'targetRef' instead of 'targetref'.

Raw Output:
{"message": "[Vale.Terms] Use 'targetRef' instead of 'targetref'.", "location": {"path": "app/_src/production/upgrades-tuning/fine-tuning.md", "range": {"start": {"line": 71, "column": 43}}}, "severity": "ERROR"}
- [from](/docs/{{ page.version }}/policies/targetref/#target-resources) level `MeshSubset` and `MeshServiceSubset` with all labels

Check failure on line 72 in app/_src/production/upgrades-tuning/fine-tuning.md

View workflow job for this annotation

GitHub Actions / Lint docs 

[vale] reported by reviewdog 🐶
[Vale.Terms] Use 'targetRef' instead of 'targetref'.

Raw Output:
{"message": "[Vale.Terms] Use 'targetRef' instead of 'targetref'.", "location": {"path": "app/_src/production/upgrades-tuning/fine-tuning.md", "range": {"start": {"line": 72, "column": 44}}}, "severity": "ERROR"}

If you define a MeshTrafficPermission with other kind, like this one:

```yaml
```policy_yaml
apiVersion: kuma.io/v1alpha1
kind: MeshTrafficPermission
metadata:
Expand Down

0 comments on commit 50103a0

Please sign in to comment.