Skip to content

Commit

Permalink
feat(reachableservices): post test tuesday changes
Browse files Browse the repository at this point in the history 
Signed-off-by: slonka <slonka@users.noreply.github.com>
  • Loading branch information
@slonka
slonka committed Nov 7, 2023
1 parent b8bcc74 commit b41b1b5
Showing 1 changed file with 9 additions and 2 deletions.
11 changes: 9 additions & 2 deletions app/_src/production/upgrades-tuning/fine-tuning.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,16 @@ Follow the {% if_version lte:2.1.x %}[transparent proxying](/docs/{{ page.versio
{% if_version gte:2.5.x %}
## Config trimming by using MeshTrafficPermission

Check warning on line 20 in app/_src/production/upgrades-tuning/fine-tuning.md

View workflow job for this annotation

GitHub Actions / Lint docs 

[vale] reported by reviewdog 🐶
[Google.Headings] 'Config trimming by using MeshTrafficPermission' should use sentence-style capitalization.

Raw Output:
{"message": "[Google.Headings] 'Config trimming by using MeshTrafficPermission' should use sentence-style capitalization.", "location": {"path": "app/_src/production/upgrades-tuning/fine-tuning.md", "range": {"start": {"line": 20, "column": 4}}}, "severity": "WARNING"}

{% warning %}
1. This feature only works with [MeshTrafficPermission](/docs/{{ page.version }}/policies/meshtrafficpermission),

Check warning on line 23 in app/_src/production/upgrades-tuning/fine-tuning.md

View workflow job for this annotation

GitHub Actions / Lint docs 

[vale] reported by reviewdog 🐶
[Google.Parens] Use parentheses judiciously.

Raw Output:
{"message": "[Google.Parens] Use parentheses judiciously.", "location": {"path": "app/_src/production/upgrades-tuning/fine-tuning.md", "range": {"start": {"line": 23, "column": 56}}}, "severity": "INFO"}
if you're using [TrafficPermission](/docs/{{ page.version }}/policies/traffic-permissions) you need to migrate to MeshTrafficPermission,

Check warning on line 24 in app/_src/production/upgrades-tuning/fine-tuning.md

View workflow job for this annotation

GitHub Actions / Lint docs 

[vale] reported by reviewdog 🐶
[Google.Parens] Use parentheses judiciously.

Raw Output:
{"message": "[Google.Parens] Use parentheses judiciously.", "location": {"path": "app/_src/production/upgrades-tuning/fine-tuning.md", "range": {"start": {"line": 24, "column": 39}}}, "severity": "INFO"}
otherwise enabling this feature could stop all traffic flow.
1. Due to [a bug](https://github.com/kumahq/kuma/issues/6589) [ExternalServices](/docs/{{ page.version }}/policies/external-services) won't work without Traffic Permissions without [Zone Egress](/docs/{{ page.version }}/production/cp-deployment/zoneegress), if you're using External Services you need to keep associated TrafficPermissions.

Check warning on line 26 in app/_src/production/upgrades-tuning/fine-tuning.md

View workflow job for this annotation

GitHub Actions / Lint docs 

[vale] reported by reviewdog 🐶
[Google.Parens] Use parentheses judiciously.

Raw Output:
{"message": "[Google.Parens] Use parentheses judiciously.", "location": {"path": "app/_src/production/upgrades-tuning/fine-tuning.md", "range": {"start": {"line": 26, "column": 85}}}, "severity": "INFO"}
{% endwarning %}

Starting with release 2.5 the problem stated in [reachable services](#reachable-services) section
can be also mitigated by defining MeshTrafficPermissions in combination with:
- `{{site.set_flag_values_prefix}}.experimental.autoReachableServices` flag (or `KUMA_EXPERIMENTAL_AUTO_REACHABLE_SERVICES` environment variable) and
can be also mitigated by defining [MeshTrafficPermissions](/docs/{{ page.version }}/policies/meshtrafficpermission) in combination with:

Check warning on line 30 in app/_src/production/upgrades-tuning/fine-tuning.md

View workflow job for this annotation

GitHub Actions / Lint docs 

[vale] reported by reviewdog 🐶
[Google.Parens] Use parentheses judiciously.

Raw Output:
{"message": "[Google.Parens] Use parentheses judiciously.", "location": {"path": "app/_src/production/upgrades-tuning/fine-tuning.md", "range": {"start": {"line": 30, "column": 59}}}, "severity": "INFO"}
- `KUMA_EXPERIMENTAL_AUTO_REACHABLE_SERVICES=true` environment variable set on **global CP** (for helm use `--set {{site.set_flag_values_prefix}}controlPlane.envVars.KUMA_EXPERIMENTAL_AUTO_REACHABLE_SERVICES=true`) and

Check warning on line 31 in app/_src/production/upgrades-tuning/fine-tuning.md

View workflow job for this annotation

GitHub Actions / Lint docs 

[vale] reported by reviewdog 🐶
[Google.Parens] Use parentheses judiciously.

Raw Output:
{"message": "[Google.Parens] Use parentheses judiciously.", "location": {"path": "app/_src/production/upgrades-tuning/fine-tuning.md", "range": {"start": {"line": 31, "column": 1}}}, "severity": "INFO"}
- [mTLS enabled in strict mode](/docs/{{ page.version }}/policies/mutual-tls/)

Switching on the flag will result in computing a graph of dependencies between the services

Check warning on line 34 in app/_src/production/upgrades-tuning/fine-tuning.md

View workflow job for this annotation

GitHub Actions / Lint docs 

[vale] reported by reviewdog 🐶
[Google.Will] Avoid using 'will'.

Raw Output:
{"message": "[Google.Will] Avoid using 'will'.", "location": {"path": "app/_src/production/upgrades-tuning/fine-tuning.md", "range": {"start": {"line": 34, "column": 23}}}, "severity": "WARNING"}
Expand Down

0 comments on commit b41b1b5

Please sign in to comment.