Bump jekyll-generator-single-source #1623

fabianrbz · 2024-01-29T16:06:32Z

Update the site to use the new version of jekyll-generator-single-source.

Most notable changes:

we added support for labeling releases
URLs now use /{{ page.release }}/ instead of /{{ page.version }} which is more accurate
the way to handle dev release changes slightly, instead of having a app/_data/docs_nav_dev.yml it needs to be named after the next release, e.g. app/_data/docs_nav_2.6.x.yml. The dev bit is handled via the app/_data/versions.yml file, by adding label: dev to the corresponding version.

This also updates:

ruby + dependencies
simplifies the way to run the app locally make clean && make run builds and runs the site, including redirects

Did you sign your commit? Instructions

Have you read Contributing guidelines?

netlify · 2024-01-29T16:06:38Z

✅ Deploy Preview for kuma ready!

Name	Link
🔨 Latest commit	`6f2fbcc`
🔍 Latest deploy log	https://app.netlify.com/sites/kuma/deploys/672cb509ad3d910008fee55d
😎 Deploy Preview	https://deploy-preview-1623--kuma.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 85 (🟢 up 2 from production) Accessibility: 90 (no change from production) Best Practices: 100 (no change from production) SEO: 92 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

lahabana · 2024-01-31T09:11:14Z

@fabianrbz can you rebase seems like there are some conflicts

fabianrbz · 2024-02-01T12:23:05Z

@lahabana test is failing due to a caching issue, can you clear the cache for that action?

lahabana · 2024-03-07T10:12:18Z

@fabianrbz is this ready to review?

fabianrbz · 2024-03-07T10:39:15Z

@lahabana yes

slonka · 2024-03-28T09:20:47Z

@fabianrbz - tests are failing, can you look into them?

lahabana · 2024-05-16T12:26:45Z

@fabianrbz are you still looking into this?

slonka · 2024-08-14T08:15:46Z

@fabianrbz are you still looking into this?

fabianrbz · 2024-08-16T09:50:01Z

@lahabana @slonka sorry, I'm not working on this atm, I might be able to find some time after summit though

app/_data/docs_nav_kuma_2.10.x.yml

Signed-off-by: Fabian Rodriguez <fabian.rodriguez@konghq.com>

Remove jekyll-plugins section, list them in the jekyll config file Signed-off-by: Fabian Rodriguez <fabian.rodriguez@konghq.com>

Skip versions that are labelled with `dev` Signed-off-by: Fabian Rodriguez <fabian.rodriguez@konghq.com>

Signed-off-by: Fabian Rodriguez <fabian.rodriguez@konghq.com>

The generators defined here should have a lower priority than the one defined in jekyll-generator-single-source. Also, medium isn't a valid priority. Signed-off-by: Fabian Rodriguez <fabian.rodriguez@konghq.com>

Signed-off-by: Fabian Rodriguez <fabian.rodriguez@konghq.com>

Signed-off-by: Charly Molter <charly.molter@konghq.com>

app/_includes/version_alert.html

app/_layouts/default.html

Signed-off-by: Charly Molter <charly.molter@konghq.com>

This fixes: kumahq/kuma-website#2073 which is needed as we moved to the latest site-generator with: kumahq/kuma-website#1623 Signed-off-by: Charly Molter <charly.molter@konghq.com>

With kumahq/kuma-website#1623 all sites use `label:dev` so it's no longer needed to have a flag for this Signed-off-by: Charly Molter <charly.molter@konghq.com>

## Motivation This fixes: kumahq/kuma-website#2073 which is needed as we moved to the latest site-generator with: kumahq/kuma-website#1623. --------- Signed-off-by: Charly Molter <charly.molter@konghq.com>

fabianrbz force-pushed the refactor-version-is branch 3 times, most recently from 3f62a48 to 6215139 Compare February 1, 2024 12:13

fabianrbz force-pushed the refactor-version-is branch 2 times, most recently from a670374 to df90f88 Compare February 23, 2024 15:33

fabianrbz marked this pull request as ready for review February 26, 2024 08:11

fabianrbz requested a review from a team as a code owner February 26, 2024 08:11

fabianrbz requested review from Automaat and bartsmykla and removed request for a team February 26, 2024 08:11

fabianrbz changed the title ~~Refactor version is~~ Bump jekyll-generator-single-source Mar 28, 2024

fabianrbz mentioned this pull request Apr 17, 2024

docs(quickstart): Add universal quickstart #1682

Merged

fabianrbz force-pushed the refactor-version-is branch from d1f836b to a1d2d4a Compare November 5, 2024 13:26

lahabana reviewed Nov 5, 2024

View reviewed changes

app/_data/docs_nav_kuma_2.10.x.yml Show resolved Hide resolved

fabianrbz added 7 commits November 5, 2024 16:09

Replace page.version with page.release

5209afe

Signed-off-by: Fabian Rodriguez <fabian.rodriguez@konghq.com>

Simplify the way we boot the app

2738528

Signed-off-by: Fabian Rodriguez <fabian.rodriguez@konghq.com>

Update docs with page.release

0da8180

Signed-off-by: Fabian Rodriguez <fabian.rodriguez@konghq.com>

Bump ruby version

75ac216

Signed-off-by: Fabian Rodriguez <fabian.rodriguez@konghq.com>

Bump jekyll-generator-single-source

c4e945e

Remove jekyll-plugins section, list them in the jekyll config file Signed-off-by: Fabian Rodriguez <fabian.rodriguez@konghq.com>

Fix site generation

fdacee8

Skip versions that are labelled with `dev` Signed-off-by: Fabian Rodriguez <fabian.rodriguez@konghq.com>

Fix links after rebase

1715272

Signed-off-by: Fabian Rodriguez <fabian.rodriguez@konghq.com>

fabianrbz added 12 commits November 5, 2024 16:09

Fix redirects

cb3d5d4

Signed-off-by: Fabian Rodriguez <fabian.rodriguez@konghq.com>

Make exe/build executable

490d5c0

Signed-off-by: Fabian Rodriguez <fabian.rodriguez@konghq.com>

Use page.release in links

d8392cd

Signed-off-by: Fabian Rodriguez <fabian.rodriguez@konghq.com>

Fix version alert

6347224

Signed-off-by: Fabian Rodriguez <fabian.rodriguez@konghq.com>

Fix link to latest version of a page

bca30a7

Signed-off-by: Fabian Rodriguez <fabian.rodriguez@konghq.com>

Bump jekyll-generator-single-source

84a9bf6

Signed-off-by: Fabian Rodriguez <fabian.rodriguez@konghq.com>

Add missing release to nav files

17dea10

Signed-off-by: Fabian Rodriguez <fabian.rodriguez@konghq.com>

Rename docs_nav_kuma_dev to docs_nav_kuma_2.10.x

a0bed31

Signed-off-by: Fabian Rodriguez <fabian.rodriguez@konghq.com>

Update versions.yml

d7df84b

Signed-off-by: Fabian Rodriguez <fabian.rodriguez@konghq.com>

Replace page.version with page.release in links

5b69179

Signed-off-by: Fabian Rodriguez <fabian.rodriguez@konghq.com>

Fix more links

bc0f381

Signed-off-by: Fabian Rodriguez <fabian.rodriguez@konghq.com>

Set the correct css classes if the page isn't the latest one

4b054e8

Signed-off-by: Fabian Rodriguez <fabian.rodriguez@konghq.com>

fabianrbz force-pushed the refactor-version-is branch from a1d2d4a to 4b054e8 Compare November 5, 2024 15:11

fabianrbz added 3 commits November 6, 2024 18:28

Set the correct priorities to generators

7087de8

The generators defined here should have a lower priority than the one defined in jekyll-generator-single-source. Also, medium isn't a valid priority. Signed-off-by: Fabian Rodriguez <fabian.rodriguez@konghq.com>

Rely on .ruby-version for setting up ruby in github actions

fa3dde7

Signed-off-by: Fabian Rodriguez <fabian.rodriguez@konghq.com>

Fix specs

a20ef07

Signed-off-by: Fabian Rodriguez <fabian.rodriguez@konghq.com>

fabianrbz force-pushed the refactor-version-is branch from acc3c43 to a20ef07 Compare November 6, 2024 17:28

lahabana added 3 commits November 7, 2024 10:58

fix policy_yaml to support release and edition

bdbbc2c

Signed-off-by: Charly Molter <charly.molter@konghq.com>

more fixes to plugins

a2f741c

Signed-off-by: Charly Molter <charly.molter@konghq.com>

Merge branch 'master' into refactor-version-is

6947c11

Signed-off-by: Charly Molter <charly.molter@konghq.com>

lahabana approved these changes Nov 7, 2024

View reviewed changes

app/_includes/version_alert.html Outdated Show resolved Hide resolved

app/_layouts/default.html Show resolved Hide resolved

ignore coreDNS for checklinks

6f2fbcc

Signed-off-by: Charly Molter <charly.molter@konghq.com>

lahabana merged commit f9202ba into kumahq:master Nov 7, 2024
15 of 16 checks passed

kong-docs mentioned this pull request Nov 8, 2024

chore(deps): bump kumahq/kuma-website from 754c9419 to 06058d89 Kong/docs.konghq.com#8122

Merged

This was referenced Nov 8, 2024

feat(version-file): use label:dev by default kumahq/ci-tools#53

Merged

ci(github): fix release.yaml to use label:dev in version.yaml kumahq/kuma#11995

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump jekyll-generator-single-source #1623

Bump jekyll-generator-single-source #1623

fabianrbz commented Jan 29, 2024

netlify bot commented Jan 29, 2024 •

edited

Loading

lahabana commented Jan 31, 2024

fabianrbz commented Feb 1, 2024

lahabana commented Mar 7, 2024

fabianrbz commented Mar 7, 2024

slonka commented Mar 28, 2024

lahabana commented May 16, 2024

slonka commented Aug 14, 2024

fabianrbz commented Aug 16, 2024

Bump jekyll-generator-single-source #1623

Bump jekyll-generator-single-source #1623

Conversation

fabianrbz commented Jan 29, 2024

netlify bot commented Jan 29, 2024 • edited Loading

✅ Deploy Preview for kuma ready!

lahabana commented Jan 31, 2024

fabianrbz commented Feb 1, 2024

lahabana commented Mar 7, 2024

fabianrbz commented Mar 7, 2024

slonka commented Mar 28, 2024

lahabana commented May 16, 2024

slonka commented Aug 14, 2024

fabianrbz commented Aug 16, 2024

netlify bot commented Jan 29, 2024 •

edited

Loading