refactor(plugins): refactor custom block plugins #2012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove separate `tip.rb` and `warning.rb` plugins, which were just copies of the same code with only difference in a block name. Now the code is the same and just registered for different tags. Additionally it unblocks a `danger` block which has stronger emphasis than `warning`. Signed-off-by: Bart Smykla <bartek@smykla.com>
bartsmykla
requested review from
michaelbeaumont
and removed request for
a team
✅ Deploy Preview for kuma ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Closed
2 tasks
Automaat
approved these changes
Oct 23, 2024
Merged
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove separate
tip.rbandwarning.rbplugins, which were just copies of the same code with only difference in a block name. Now the code is the same and just registered for different tags.Additionally it unblocks a
dangerblock which has stronger emphasis thanwarning.Did you sign your commit? Instructions: 👍
Have you read Contributing guidelines?: 👍