-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove mesh metric otel from experimental #2062
Conversation
Signed-off-by: John Harris <john@johnharris.io>
✅ Deploy Preview for kuma ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add {% if_version gte:2.9.x %}
for this change so that we remove experimental only form 2.9.x version
Is 2.9 correct? Further down there is:
Also in the nav the Assuming that's correct (2.7 onwards is out of experimental according to the two places above), I've amended this PR with a guard but for 2.7 (not 2.9). |
Signed-off-by: John Harris <john@johnharris.io>
@johnharris85 do we have |
Remove the
experimental
designation for OTEL in MeshMetric.