Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove mesh metric otel from experimental #2062

Merged
merged 2 commits into from
Nov 5, 2024
Merged

Conversation

johnharris85
Copy link
Contributor

Remove the experimental designation for OTEL in MeshMetric.

Signed-off-by: John Harris <john@johnharris.io>
@johnharris85 johnharris85 requested a review from a team as a code owner November 4, 2024 19:16
@johnharris85 johnharris85 requested review from slonka and Icarus9913 and removed request for a team November 4, 2024 19:16
Copy link

netlify bot commented Nov 4, 2024

Deploy Preview for kuma ready!

Name Link
🔨 Latest commit d58f33e
🔍 Latest deploy log https://app.netlify.com/sites/kuma/deploys/6729609ab7a0790008836a35
😎 Deploy Preview https://deploy-preview-2062--kuma.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 89 (🔴 down 3 from production)
Accessibility: 90 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@Automaat Automaat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add {% if_version gte:2.9.x %} for this change so that we remove experimental only form 2.9.x version

@johnharris85
Copy link
Contributor Author

johnharris85 commented Nov 4, 2024

Is 2.9 correct? Further down there is:

{% if_version gte:2.7.x %}
#### OpenTelemetry
...

Also in the nav the experimental is gone from 2.7 onwards?

Assuming that's correct (2.7 onwards is out of experimental according to the two places above), I've amended this PR with a guard but for 2.7 (not 2.9).

Signed-off-by: John Harris <john@johnharris.io>
@Automaat
Copy link
Contributor

Automaat commented Nov 5, 2024

@johnharris85 do we have experimental somewhere in nav bar? I cannot find it. I see that you put gte 2.7 I think we should remove experimental only from the newest version. It was experimental in 2.7, and it had some bugs. Also, it will motivate users to use the newest version

@johnharris85 johnharris85 merged commit e440b17 into master Nov 5, 2024
17 checks passed
@johnharris85 johnharris85 deleted the mesh-metric-ga branch November 5, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants