Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(guides): move guides to use new MeshService by default #2069

Merged
merged 4 commits into from
Nov 7, 2024
Merged

feat(guides): move guides to use new MeshService by default #2069

merged 4 commits into from
Nov 7, 2024

Conversation

Automaat
Copy link
Contributor

@Automaat Automaat commented Nov 6, 2024

We've discussed that for version newer than 2.9.x We should push new users to use new MeshService. This pr updated and fixes guides to work with MeshService mode Exclusive

@Automaat
feat(guides): move guides to use new MeshService by default for versi…
43665e1 
…on newer than 2.9.x

Signed-off-by: Marcin Skalski <skalskimarcin33@gmail.com>
@Automaat
feat(guides): move guides to use new MeshService by default for versi…
df3a4ec 
…on newer than 2.9.x

Signed-off-by: Marcin Skalski <skalskimarcin33@gmail.com>
@Automaat Automaat requested a review from a team as a code owner November 6, 2024 16:48
@Automaat Automaat requested review from michaelbeaumont and lukidzi and removed request for a team November 6, 2024 16:48
@netlify Netlify
Copy link

netlify bot commented Nov 6, 2024 •
edited
Loading

✅ Deploy Preview for kuma ready!

Name Link
🔨 Latest commit 8e72a53
🔍 Latest deploy log https://app.netlify.com/sites/kuma/deploys/672c76535bd98100088f3b07
😎 Deploy Preview https://deploy-preview-2069--kuma.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 95 (🟢 up 14 from production)
Accessibility: 90 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

lahabana
lahabana approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@lahabana lahabana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the getting started and the builtin gateway guides and it worked well!
Thanks for improving this!

app/_src/quickstart/universal-demo.md Show resolved Hide resolved
app/_src/guides/gateway-builtin.md Outdated Show resolved Hide resolved
Automaat and others added 2 commits November 7, 2024 08:55
@Automaat @lahabana
Update app/_src/guides/gateway-builtin.md
f6db904 
Co-authored-by: Charly Molter <charly@molter.io>
Signed-off-by: Marcin Skalski <skalskimarcin33@gmail.com>
@Automaat
feat(guides): fix copying command in guide
8e72a53 
Signed-off-by: Marcin Skalski <skalskimarcin33@gmail.com>
@Automaat Automaat merged commit 4de1239 into kumahq:master Nov 7, 2024
16 checks passed
@Automaat Automaat deleted the feat/move-guides-to-new-ms branch November 7, 2024 11:18
@kong-docs kong-docs mentioned this pull request Nov 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahabana lahabana lahabana approved these changes

@michaelbeaumont michaelbeaumont Awaiting requested review from michaelbeaumont michaelbeaumont is a code owner automatically assigned from kumahq/kuma-website-maintainers

@lukidzi lukidzi Awaiting requested review from lukidzi lukidzi is a code owner automatically assigned from kumahq/kuma-website-maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Automaat @lahabana