docs(using): clarify service upstream annotations for services in namespace not having sidecar injection enabled #2091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d sidecar injection Signed-off-by: Jay Chen <1180092+jijiechen@users.noreply.github.com>
jijiechen
requested review from
lukidzi and
Icarus9913
and removed request for
a team
✅ Deploy Preview for kuma ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
lahabana
approved these changes
Nov 19, 2024
lahabana
reviewed
Nov 19, 2024
| @@ -42,7 +42,12 @@ have the [`ingress.kubernetes.io/service-upstream=true`](https://docs.konghq.com | |||
| With this annotation the ingress controller sends traffic to the `Service` IP instead of directly to the endpoints selected by the `Service`. | |||
| {{site.mesh_product_name}} then routes this `Service` traffic to endpoints as configured by the mesh. | |||
| {{site.mesh_product_name}} automatically injects this annotation for every | |||
| `Service` that is part of the mesh. | |||
| `Service` that is in namespaces labeled as `kuma.io/sidecar-injection=enabled`. | |||
There was a problem hiding this comment.
Suggested change
| `Service` that is in namespaces labeled as `kuma.io/sidecar-injection=enabled`. | |
| `Service` that is in a namespace with the label `kuma.io/sidecar-injection=enabled`. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes kumahq/kuma#11994
Did you sign your commit? Instructions
Have you read Contributing guidelines?
Preview link: