Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dataplane): use dataplane kind in policy examples #2201

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(dataplane): use dataplane kind in policy examples #2201

wants to merge 1 commit into from
+1,405 −59

Conversation

Automaat
Copy link
Contributor

We've added new kind Dataplane we should use it in policies examples in favour of deprecated MeshSubset

@Automaat
feat(dataplane): use dataplane kind in policy examples
4fa6dfc 
Signed-off-by: Marcin Skalski <skalskimarcin33@gmail.com>
@Automaat Automaat requested a review from a team as a code owner February 27, 2025 12:59
@Automaat Automaat requested review from slonka and bartsmykla and removed request for a team February 27, 2025 12:59
@netlify Netlify
Copy link

netlify bot commented Feb 27, 2025 •
edited
Loading

✅ Deploy Preview for kuma ready!

Name Link
🔨 Latest commit 4fa6dfc
🔍 Latest deploy log https://app.netlify.com/sites/kuma/deploys/67c061c4557dee000843f06c
😎 Deploy Preview https://deploy-preview-2201--kuma.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 52 (🔴 down 24 from production)
Accessibility: 90 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

lukidzi
lukidzi reviewed Feb 28, 2025
View reviewed changes
app/_src/policies/meshcircuitbreaker.md
targetRef:
kind: Dataplane
labels:
app: web
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we use rules here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will, but I started with just changing docs for dataplane kind. We have separate issues for rules api

@lobkovilya
Copy link
Contributor

I grepped with

rg -U "targetRef:\n\s+kind: .*\n\s+tags:\n\s+app: .*" .

and noticed more files. Please also check guides and quickstart:

app/_src/guides/progressively-rolling-in-strict-mtls.md
app/_src/guides/gateway-api.md
app/_src/guides/federate.md
app/_src/guides/gateway-delegated.md
app/_src/guides/gateway-builtin.md
app/_src/quickstart/kubernetes-demo.md

@Automaat
Copy link
Contributor Author

@lobkovilya I've just merged it: #2203

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukidzi lukidzi lukidzi left review comments

@lobkovilya lobkovilya lobkovilya approved these changes

@slonka slonka Awaiting requested review from slonka slonka is a code owner automatically assigned from kumahq/kuma-website-maintainers

@bartsmykla bartsmykla Awaiting requested review from bartsmykla bartsmykla is a code owner automatically assigned from kumahq/kuma-website-maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Automaat @lobkovilya @lukidzi