Skip to content

Commit

Permalink
ci(e2e): disable flaking tests (#9350)
Browse files Browse the repository at this point in the history
Following our earlier decision, I'm disabling flaking tests. When
amount of disabled tests because of flakes exceed 10, we should
stop other work and focus on fixing flakes.

Signed-off-by: Bart Smykla <bartek@smykla.com>
  • Loading branch information
bartsmykla authored and kumahq[bot] committed Oct 3, 2024
1 parent ba2a083 commit 5bf5846
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
3 changes: 2 additions & 1 deletion test/e2e_env/kubernetes/gateway/delegated/meshproxypatch.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@ func MeshProxyPatch(config *Config) func() {
GinkgoHelper()

return func() {
It("should add a header using Lua filter", func() {
// Disabled because of flakes: https://github.com/kumahq/kuma/issues/9348
XIt("should add a header using Lua filter", func() {
// given
meshProxyPatch := fmt.Sprintf(`
apiVersion: kuma.io/v1alpha1
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,8 @@ func ReachableServices() {
}, "30s", "500ms", MustPassRepeatedly(10)).Should(Succeed())
})

It("should not be able to non reachable services", func() {
// Disabled because of flakiness: https://github.com/kumahq/kuma/issues/9349
XIt("should not be able to non reachable services", func() {
Consistently(func(g Gomega) {
// when
response, err := client.CollectFailure(
Expand Down

0 comments on commit 5bf5846

Please sign in to comment.