Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose config.cluster.v3.Cluster.LeastRequestLbConfig.active_request_bias in TrafficRoute policy #2422

Closed
bdecoste opened this issue Jul 23, 2021 · 10 comments · Fixed by #8553
Closed

Expose config.cluster.v3.Cluster.LeastRequestLbConfig.active_request_bias in TrafficRoute policy #2422

bdecoste opened this issue Jul 23, 2021 · 10 comments · Fixed by #8553
Labels
area/api area/envoy area/performance triage/accepted The issue was reviewed and is complete enough to start working on it

Comments

@bdecoste
Copy link
Contributor

bdecoste commented Jul 23, 2021 •
edited
Loading

Summary

I'd like to be able to configure config.cluster.v3.Cluster.LeastRequestLbConfig.active_request_bias via a TrafficRoute

https://www.envoyproxy.io/docs/envoy/latest/api-v3/config/cluster/v3/cluster.proto#envoy-v3-api-msg-config-cluster-v3-cluster-leastrequestlbconfig

https://kuma.io/docs/1.2.2/policies/traffic-route/#usage
@jpeach
Copy link
Contributor

jpeach commented Jul 25, 2021 •
edited
Loading

What situation would benefit from this configuration? Is there some bias value that would be generally beneficial for everyone?

@bdecoste
Copy link
Contributor Author

bdecoste commented Aug 5, 2021

This would also require exposing the ability to configure weights for individual services. Currently the weights are only set !=1 when there is inter-zone communication and a zone has >1 instances of a particular service.

active_request_bias is only valuable when there are endpoints with different weights. The value to the user would be to be able to control the load-balancing behavior to different endpoints with different weights/resources.

@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Dec 25, 2021
@github-actions
Copy link
Contributor

This issue was inactive for 30 days it will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant please comment on it promptly or attend the next triage meeting.

@lahabana lahabana added triage/pending This issue will be looked at on the next triage meeting and removed triage/stale Inactive for some time. It will be triaged again labels Jul 5, 2022
@lahabana lahabana mentioned this issue Aug 2, 2022
Closed
@jakubdyszkiewicz jakubdyszkiewicz added triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/pending This issue will be looked at on the next triage meeting labels Aug 22, 2022
@jakubdyszkiewicz
Copy link
Contributor

Triage: most likely this will be implemented in the new traffic route.

@michaelbeaumont
Copy link
Contributor

@lahabana is this something we want in the first version of TrafficRoute? We'd need to configure weights for particular instances of a given service if I understand correctly. Definitely not a trivial configuration

@lahabana
Copy link
Contributor

No I related this to the route issue just to keep these kind of features when designing the policy

@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Feb 17, 2023
@github-actions
Copy link
Contributor

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@slonka
Copy link
Contributor

slonka commented Mar 1, 2023

I don't see this being implemented yet, removing stale.

@slonka slonka removed the triage/stale Inactive for some time. It will be triaged again label Mar 1, 2023
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label May 31, 2023
@github-actions
Copy link
Contributor

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@lahabana lahabana removed the triage/stale Inactive for some time. It will be triaged again label May 31, 2023
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Aug 30, 2023
@github-actions
Copy link
Contributor

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@lahabana lahabana removed the triage/stale Inactive for some time. It will be triaged again label Sep 5, 2023
@bartsmykla bartsmykla changed the title Expose config.cluster.v3.Cluster.LeastRequestLbConfig.active_request_bias in Kuma TrafficRoute policy Expose config.cluster.v3.Cluster.LeastRequestLbConfig.active_request_bias in Kuma TrafficRoute policy Nov 20, 2023
@bartsmykla bartsmykla changed the title Expose config.cluster.v3.Cluster.LeastRequestLbConfig.active_request_bias in Kuma TrafficRoute policy Expose config.cluster.v3.Cluster.LeastRequestLbConfig.active_request_bias in TrafficRoute policy Nov 20, 2023
@lukidzi lukidzi mentioned this issue Dec 6, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/api area/envoy area/performance triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(MeshLoadBalancingStrategy): add option to configure ActiveRequestBias lukidzi/kuma
6 participants
@jpeach @bdecoste @lahabana @michaelbeaumont @slonka @jakubdyszkiewicz