Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(MeshLoadBalancingStrategy): add option to configure ActiveRequestBias #8553

Merged
merged 4 commits into from
Dec 7, 2023

Conversation

lukidzi
Copy link
Contributor

@lukidzi lukidzi commented Dec 6, 2023

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues -- fix: 2422
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
@lahabana lahabana changed the title feat(kuma-cp): add option to configure ActiveRequestBias in MLBS feat(MeshLoadBalancingStrategy): add option to configure ActiveRequestBias Dec 6, 2023
@lahabana
Copy link
Contributor

lahabana commented Dec 6, 2023

Btw updated the PR title ^

Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
@lukidzi lukidzi marked this pull request as ready for review December 6, 2023 16:21
@lukidzi lukidzi requested a review from a team as a code owner December 6, 2023 16:21
@lukidzi lukidzi requested review from michaelbeaumont and bartsmykla and removed request for a team December 6, 2023 16:21
Co-authored-by: Bart Smykla <bartek@smykla.com>
Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
@lukidzi lukidzi merged commit 938e93b into kumahq:master Dec 7, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose config.cluster.v3.Cluster.LeastRequestLbConfig.active_request_bias in TrafficRoute policy
3 participants