Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MeshHTTPRoute basic api implementation #5470

Closed
michaelbeaumont opened this issue Dec 8, 2022 · 4 comments
Closed

MeshHTTPRoute basic api implementation #5470

michaelbeaumont opened this issue Dec 8, 2022 · 4 comments
Assignees
Labels
kind/feature New feature triage/accepted The issue was reviewed and is complete enough to start working on it

Comments

@michaelbeaumont
Copy link
Contributor

michaelbeaumont commented Dec 8, 2022

Description

Implement #4743

  • Implement plugin ordering
  • "Feature flag" for new routes -> if new route policies exist, only use new route policies
  • Implement MeshHTTPRoute targetRef-based & matches-based merging
    • this requires significant refactoring because it's assumed everywhere that the to struct has a Default field
  • Generate outbound listeners from Dataplane spec
    • handles default route/TcpProxy
  • Generate clusters from new routes
    • 1st iteration - same cluster generation
  • Generate routes on outbound listeners from new routes
    • Including ExternalServices
    • kuma.io/service for Dataplanes has priority over ExternalServices
      • document and warn about this
    • targetRef.kind: ExternalService as backendRef?
  • Generate endpoints
  • ZoneIngress support for new routes
    • needs only backendRefs for destinations
  • No MeshGateway support
@michaelbeaumont michaelbeaumont added triage/pending This issue will be looked at on the next triage meeting kind/feature New feature triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/pending This issue will be looked at on the next triage meeting labels Dec 8, 2022
@michaelbeaumont
Copy link
Contributor Author

I think this can be parallelized:

  1. refactor the policy code to support a plugin with a policy that doesn't have the expected To structure
  2. implement the plugin given a merged "rules" view of all routes

@lahabana
Copy link
Contributor

lahabana commented Jan 3, 2023

FYI this issue doesn't cover Mirror which is covered by: #724

@lahabana lahabana changed the title MeshHTTPRoute implementation MeshHTTPRoute basic api implementation Jan 3, 2023
@lahabana
Copy link
Contributor

As other issues are tracked somewhere else going to close this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Development

No branches or pull requests

2 participants