Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(MeshHTTPRoute): initial plugin #5530

Merged
merged 16 commits into from
Jan 9, 2023
Merged

feat(MeshHTTPRoute): initial plugin #5530

merged 16 commits into from
Jan 9, 2023

Conversation

michaelbeaumont
Copy link
Contributor

@michaelbeaumont michaelbeaumont commented Dec 20, 2022 •
edited by lahabana
Loading

This is only the plugin, the resource is extremely simplied and there is no extra validation.

Checklist prior to review

  • Link to docs PR or issue --
  • Link to UI issue or PR --
  • Is the issue worked on linked? -- MeshHTTPRoute basic api implementation #5470
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) --
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Unit Tests --
  • E2E Tests -- none
  • Manual Universal Tests --
  • Manual Kubernetes Tests --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

Changelog: feat(policy): implement MeshHTTPRoute policy

@michaelbeaumont michaelbeaumont requested review from a team, jakubdyszkiewicz and bartsmykla and removed request for a team December 20, 2022 12:35
@michaelbeaumont michaelbeaumont marked this pull request as draft December 20, 2022 12:41
@michaelbeaumont michaelbeaumont force-pushed the feat/meshhttproute branch 9 times, most recently from e2c71aa to 0cc609a Compare December 23, 2022 09:47
@michaelbeaumont
feat(MeshHTTPRoute): initial types
49d30af 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont
chore: generated files
8d6710e 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont
feat(MeshHTTPRoute): initial plugin
8b0ed17 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont
test(MeshHTTPRoute): initial plugin unit tests
4c915d8 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont marked this pull request as ready for review January 3, 2023 13:39
jakubdyszkiewicz
jakubdyszkiewicz reviewed Jan 4, 2023
View reviewed changes
pkg/plugins/policies/meshhttproute/api/v1alpha1/meshhttproute.go Outdated Show resolved Hide resolved
pkg/plugins/policies/meshhttproute/plugin/v1alpha1/plugin.go Outdated Show resolved Hide resolved
pkg/plugins/policies/meshhttproute/plugin/v1alpha1/plugin.go Outdated Show resolved Hide resolved
pkg/plugins/policies/meshhttproute/plugin/v1alpha1/listeners.go Show resolved Hide resolved
pkg/plugins/policies/meshhttproute/plugin/v1alpha1/listeners.go Outdated Show resolved Hide resolved
pkg/plugins/policies/meshhttproute/plugin/v1alpha1/plugin_test.go Outdated Show resolved Hide resolved
pkg/plugins/policies/meshhttproute/plugin/v1alpha1/plugin_test.go Show resolved Hide resolved
pkg/plugins/policies/meshhttproute/plugin/v1alpha1/plugin_test.go Show resolved Hide resolved
pkg/plugins/policies/meshhttproute/plugin/v1alpha1/plugin_test.go Outdated Show resolved Hide resolved
pkg/plugins/policies/meshhttproute/plugin/v1alpha1/plugin_test.go Outdated Show resolved Hide resolved
@michaelbeaumont
fix: don't create an httpconnectionmanager per route
70916e8 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont
fix: omitempty, review comments
99c30d0 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont
test: use samples
acb9dcd 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
lahabana
lahabana reviewed Jan 5, 2023
View reviewed changes
Copy link
Contributor

@lahabana lahabana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think reworking MatchedPolicies is required to be able to make the inspect API work in the future.

@michaelbeaumont
fix: use clusterCache
f518553 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont
refactor: remove unnecessary internal/external cluster tracking
84dd181 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont
refactor: use slices.Equal
ff06e06 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont
fix: allow user rules to overwrite default passthrough rule
ed4f1ad 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont
refactor: remove Default field
6ef25f0 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
This was referenced Jan 9, 2023
Merged
Closed
@michaelbeaumont
Copy link
Contributor Author

Outstanding: #5470 (comment)

@michaelbeaumont michaelbeaumont merged commit 881bea9 into kumahq:master Jan 9, 2023
@michaelbeaumont michaelbeaumont deleted the feat/meshhttproute branch January 9, 2023 14:58
bartsmykla pushed a commit to bartsmykla/kuma that referenced this pull request Jan 14, 2023
@michaelbeaumont @bartsmykla
feat(MeshHTTPRoute): initial plugin (kumahq#5530)
15ed591 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: Bart Smykla <bartek@smykla.com>
@shaneutt shaneutt mentioned this pull request Feb 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahabana lahabana lahabana left review comments

@jakubdyszkiewicz jakubdyszkiewicz jakubdyszkiewicz approved these changes

@lobkovilya lobkovilya lobkovilya approved these changes

@bartsmykla bartsmykla Awaiting requested review from bartsmykla

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@michaelbeaumont @lahabana @jakubdyszkiewicz @lobkovilya