-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(MeshHTTPRoute): initial plugin #5530
Merged
michaelbeaumont
merged 16 commits into
kumahq:master
from
michaelbeaumont:feat/meshhttproute
Jan 9, 2023
Merged
feat(MeshHTTPRoute): initial plugin #5530
michaelbeaumont
merged 16 commits into
kumahq:master
from
michaelbeaumont:feat/meshhttproute
Jan 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelbeaumont
requested review from
a team,
jakubdyszkiewicz and
bartsmykla
and removed request for
a team
December 20, 2022 12:35
michaelbeaumont
force-pushed
the
feat/meshhttproute
branch
9 times, most recently
from
December 23, 2022 09:47
e2c71aa
to
0cc609a
Compare
michaelbeaumont
force-pushed
the
feat/meshhttproute
branch
from
January 3, 2023 08:29
0cc609a
to
db0a8f7
Compare
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
michaelbeaumont
force-pushed
the
feat/meshhttproute
branch
from
January 3, 2023 13:38
db0a8f7
to
4c915d8
Compare
pkg/plugins/policies/meshhttproute/api/v1alpha1/meshhttproute.go
Outdated
Show resolved
Hide resolved
pkg/plugins/policies/meshhttproute/plugin/v1alpha1/listeners.go
Outdated
Show resolved
Hide resolved
pkg/plugins/policies/meshhttproute/plugin/v1alpha1/plugin_test.go
Outdated
Show resolved
Hide resolved
pkg/plugins/policies/meshhttproute/plugin/v1alpha1/plugin_test.go
Outdated
Show resolved
Hide resolved
pkg/plugins/policies/meshhttproute/plugin/v1alpha1/plugin_test.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
michaelbeaumont
force-pushed
the
feat/meshhttproute
branch
from
January 5, 2023 08:53
93d0928
to
99c30d0
Compare
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
lahabana
reviewed
Jan 5, 2023
pkg/plugins/policies/meshhttproute/api/v1alpha1/meshhttproute.go
Outdated
Show resolved
Hide resolved
lahabana
reviewed
Jan 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think reworking MatchedPolicies
is required to be able to make the inspect API work in the future.
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
michaelbeaumont
force-pushed
the
feat/meshhttproute
branch
from
January 5, 2023 13:38
3b1ee40
to
ed4f1ad
Compare
lobkovilya
reviewed
Jan 5, 2023
pkg/plugins/policies/meshhttproute/api/v1alpha1/zz_generated.resource.go
Outdated
Show resolved
Hide resolved
lobkovilya
reviewed
Jan 6, 2023
pkg/plugins/policies/meshhttproute/api/v1alpha1/meshhttproute.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
This was referenced Jan 9, 2023
Outstanding: #5470 (comment) |
jakubdyszkiewicz
approved these changes
Jan 9, 2023
lobkovilya
approved these changes
Jan 9, 2023
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
bartsmykla
pushed a commit
to bartsmykla/kuma
that referenced
this pull request
Jan 14, 2023
Signed-off-by: Mike Beaumont <mjboamail@gmail.com> Signed-off-by: Bart Smykla <bartek@smykla.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is only the plugin, the resource is extremely simplied and there is no extra validation.
Checklist prior to review
MeshHTTPRoute
basic api implementation #5470syscall.Mkfifo
have equivalent implementation on the other OS --UPGRADE.md
? --> Changelog:
entry here or add aci/
label to run fewer/more tests?