Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize KDS V2 resource syncer #7649

Closed
jakubdyszkiewicz opened this issue Sep 5, 2023 · 0 comments · Fixed by #7654
Closed

Optimize KDS V2 resource syncer #7649

jakubdyszkiewicz opened this issue Sep 5, 2023 · 0 comments · Fixed by #7654
Assignees
Labels
kind/improvement Improvement on an existing feature triage/accepted The issue was reviewed and is complete enough to start working on it

Comments

@jakubdyszkiewicz
Copy link
Contributor

Description

Instead of calling

if err := s.resourceStore.List(ctx, downstream); err != nil {

we should do

keys := resourcekeys(ResourceAdded) + ResourceRemoved
if err := s.resourceStore.List(ctx, downstream, ListByKeys(keys); err != nil {

This filter does not exist. We need to implement this in paginated resource store so it's by default available for all store and additionally in postgres we need to support native query.

On the InitialRequest we don't want to set this filter.

@jakubdyszkiewicz jakubdyszkiewicz added triage/pending This issue will be looked at on the next triage meeting kind/feature New feature labels Sep 5, 2023
@jakubdyszkiewicz jakubdyszkiewicz added triage/accepted The issue was reviewed and is complete enough to start working on it kind/improvement Improvement on an existing feature and removed triage/pending This issue will be looked at on the next triage meeting kind/feature New feature labels Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/improvement Improvement on an existing feature triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants