Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(kds): pass resource keys to resourceStore for delta kds #7654

Merged
merged 7 commits into from
Sep 7, 2023
Merged

feat(kds): pass resource keys to resourceStore for delta kds #7654

merged 7 commits into from
Sep 7, 2023

Conversation

lukidzi
Copy link
Contributor

@lukidzi lukidzi commented Sep 5, 2023 •
edited
Loading

Checklist prior to review

Added option to list only elements from the database that have changed so we don't need to retrieve all the data each time. We can configure it and by default, it's turned off.

  • Link to relevant issue as well as docs and UI issues -- fix: Optimize KDS V2 resource syncer #7649
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

@lukidzi
feat(kuma-cp): pass resource keys to postgres query for delta kds
d70e07a 
Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
@lukidzi lukidzi added the ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully) label Sep 5, 2023
@lukidzi
feat(kuma-cp): added configuration option, default disabled
a2f6645 
Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
@lukidzi
fix(kuma-cp): added test and fixed logic
f41709d 
Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
@lukidzi lukidzi marked this pull request as ready for review September 6, 2023 07:08
@lukidzi lukidzi requested a review from a team as a code owner September 6, 2023 07:08
@lukidzi lukidzi requested review from Automaat and bartsmykla and removed request for a team September 6, 2023 07:08
lahabana
lahabana reviewed Sep 6, 2023
View reviewed changes
pkg/kds/v2/store/sync.go Outdated Show resolved Hide resolved
lahabana
lahabana reviewed Sep 6, 2023
View reviewed changes
pkg/kds/v2/store/sync.go Outdated Show resolved Hide resolved
@lukidzi
feat(kuma-cp): code review changes
c484c9c 
Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
@lukidzi
feat(kuma-cp): added test case with max query configuration
537eae9 
Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
jakubdyszkiewicz
jakubdyszkiewicz reviewed Sep 6, 2023
View reviewed changes
pkg/plugins/resources/postgres/pgx_store.go Outdated Show resolved Hide resolved
pkg/core/resources/store/pagination_store.go Outdated Show resolved Hide resolved
pkg/core/resources/store/pagination_store.go Outdated Show resolved Hide resolved
@lukidzi
feat(kuma-cp): changed to map, and removed filter from query
3372fe0 
Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
@lukidzi
feat(kuma-cp): refactor method based on review
176440f 
Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
@lukidzi lukidzi merged commit 25f1e76 into kumahq:master Sep 7, 2023
5 checks passed
@lahabana lahabana changed the title feat(kuma-cp): pass resource keys to postgres query for delta kds feat(kds): pass resource keys to resourceStore for delta kds Nov 3, 2023
@BrewTestBot BrewTestBot mentioned this pull request Nov 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahabana lahabana lahabana left review comments

@jakubdyszkiewicz jakubdyszkiewicz jakubdyszkiewicz approved these changes

@Automaat Automaat Awaiting requested review from Automaat Automaat is a code owner automatically assigned from kumahq/kuma-maintainers

@bartsmykla bartsmykla Awaiting requested review from bartsmykla bartsmykla is a code owner automatically assigned from kumahq/kuma-maintainers

Assignees
No one assigned
Labels
ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optimize KDS V2 resource syncer
3 participants
@lukidzi @lahabana @jakubdyszkiewicz