migrate from github.com/golang/protobuf/ptypes to google.golang.org/protobuf/types/known #10023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmorel-35
requested review from
jijiechen,
bartsmykla and
lukidzi
and removed request for
a team
mmorel-35
force-pushed
the
protobuf_v2
branch
2 times, most recently
from
0f15108
to
a9872b3
Compare
go.mod
Outdated
| @@ -13,7 +13,7 @@ require ( | |||
| github.com/containernetworking/cni v1.1.2 | |||
| github.com/containernetworking/plugins v1.4.1 | |||
| github.com/emicklei/go-restful/v3 v3.12.0 | |||
| github.com/envoyproxy/go-control-plane v0.12.0 | |||
| github.com/envoyproxy/go-control-plane v0.12.1-0.20240419124334-0cebb2f428b3 | |||
There was a problem hiding this comment.
@lobkovilya can we do it? I think replace won't work
There was a problem hiding this comment.
yes the replace won't work in this case, I checked locally
lahabana
requested changes
Apr 26, 2024
mmorel-35
force-pushed
the
protobuf_v2
branch
3 times, most recently
from
a0a42a1
to
5343197
Compare
…rotobuf/types/known Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
|
@lukidzi is this something that can be unblocked now that we moved to newer go-control-plane? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
migrate from
github.com/golang/protobuf/ptypestogoogle.golang.org/protobuf/types/knownChecklist prior to review
syscall.Mkfifohave equivalent implementation on the other OS --ci/labels to run additional/fewer testsUPGRADE.md? --