Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): set envoy version conditionally (backport of #10538) #10551

Closed
wants to merge 1 commit into from

Conversation

lobkovilya
Copy link
Contributor

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
@lobkovilya lobkovilya requested a review from a team as a code owner June 19, 2024 08:43
@lobkovilya lobkovilya requested review from jijiechen and lukidzi and removed request for a team June 19, 2024 08:43
@michaelbeaumont michaelbeaumont changed the title [manual-merge] fix(build): set envoy version conditionally (#10538) fix(build): set envoy version conditionally (backport of #10538) Jun 19, 2024
@lobkovilya lobkovilya added the ci/skip-e2e-test PR: Don't run e2e tests label Jun 19, 2024
@lobkovilya lobkovilya enabled auto-merge (squash) June 19, 2024 08:45
@jakubdyszkiewicz
Copy link
Contributor

I don't understand this change. Can you add a description with "why do we need it" or link the issue?

@jakubdyszkiewicz
Copy link
Contributor

ok, I see it's a backport. I can't see anything in the original PR as well :/
#10538

@lahabana
Copy link
Contributor

Why are we getting a backport for 2.8 into master? That's not a backport it's a "frontport"... It's important as we're 10 people to now build systematic processes on these things...

@lahabana
Copy link
Contributor

Also wasn't there a thing to auto merge branches?

@lobkovilya lobkovilya disabled auto-merge June 19, 2024 09:52
@lobkovilya lobkovilya closed this Jun 20, 2024
@lahabana lahabana deleted the cherry-pick-10538 branch September 20, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/skip-e2e-test PR: Don't run e2e tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants