Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(meshmultizoneservice): api #10643

Merged

Conversation

jakubdyszkiewicz
Copy link
Contributor

@jakubdyszkiewicz jakubdyszkiewicz commented Jun 26, 2024

Checklist prior to review

MeshMultiZoneService api and validation.

xref #10507

Name is still under consideration, but I'd like to move forward with the rest of implem. We can still rename this before the next minor release.

The only divergence from the MADR is that instead of list of zones in status I have a list of matched mesh service. I think this will help XDS generation and can be useful in the GUI.

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

Changelog: feat(MeshMultizoneService): support multizone deployments of mesh services.

Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@jakubdyszkiewicz jakubdyszkiewicz requested a review from a team as a code owner June 26, 2024 10:11
@jakubdyszkiewicz jakubdyszkiewicz requested review from lukidzi and kongmesh and removed request for a team June 26, 2024 10:11
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@jakubdyszkiewicz jakubdyszkiewicz merged commit 2531468 into kumahq:master Jun 26, 2024
15 checks passed
@jakubdyszkiewicz jakubdyszkiewicz deleted the feat/mesh-multizone-services branch June 26, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants