Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(kuma-cp): create a list of outbounds to use in plugins instead of the dpp.networking.outbound #11125

Merged
merged 6 commits into from
Aug 20, 2024

Conversation

lobkovilya
Copy link
Contributor

@lobkovilya lobkovilya commented Aug 16, 2024

Today mesh_proxy_builder.go and dataplane_proxy_builder.go always set a list of outbounds to the dataplane.spec.networking.outbound field. The field is a proto field (so it's a public API), it limits us in adding additional info to outbounds.

This PR creates a new list Outbounds in the Proxy structure, all new plugins should take outbounds from this list. In the next PR, the Outbound structure will get additional field ResourceIdentifier for new outbounds.

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

… the 'dpp.GetOutbounds()'

Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya lobkovilya marked this pull request as ready for review August 19, 2024 08:13
@lobkovilya lobkovilya requested a review from a team as a code owner August 19, 2024 08:13
@lobkovilya lobkovilya requested review from michaelbeaumont and slonka and removed request for a team August 19, 2024 08:13
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>

# Conflicts:
#	pkg/plugins/policies/meshhttproute/plugin/v1alpha1/plugin_test.go
#	pkg/plugins/policies/meshtcproute/plugin/v1alpha1/plugin_test.go
#	pkg/plugins/policies/meshtimeout/plugin/v1alpha1/plugin.go
@lobkovilya lobkovilya merged commit 95feba3 into kumahq:master Aug 20, 2024
15 checks passed
@lobkovilya lobkovilya deleted the refactor/move-outbounds-from-dpp branch August 20, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants