-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(api-server): skip display-name label for service insight #11508
Open
Icarus9913
wants to merge
4
commits into
kumahq:master
Choose a base branch
from
Icarus9913:feat/wk/skip-display-name
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Icarus9913
requested review from
jijiechen and
lukidzi
and removed request for
a team
September 22, 2024 08:48
Icarus9913
force-pushed
the
feat/wk/skip-display-name
branch
2 times, most recently
from
September 22, 2024 09:43
2477086
to
231f54e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add a test
Signed-off-by: Icarus Wu <icaruswu66@qq.com>
Signed-off-by: Icarus Wu <icaruswu66@qq.com>
I'm adding the test |
Icarus9913
force-pushed
the
feat/wk/skip-display-name
branch
from
October 24, 2024 14:44
231f54e
to
6d92b51
Compare
Signed-off-by: Icarus Wu <icaruswu66@qq.com>
Icarus9913
force-pushed
the
feat/wk/skip-display-name
branch
from
October 24, 2024 14:45
6d92b51
to
cb254a9
Compare
Since our unit tests are written in universal memory cache store mode rather than k8s store mode, it's a little bit trivial to add/rewrite that framewrok. So, let's just add this label manually to the object that we store for the test. |
Signed-off-by: Icarus Wu <icaruswu66@qq.com>
jakubdyszkiewicz
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This API would list the SeviceInsight resources with k8s mode, in which the common method GetLabels would be called and supplement the
display-name
for theMeta
.So, let's just add a mapper function to remove that label in the API-Server component.
Checklist prior to review
syscall.Mkfifo
have equivalent implementation on the other OS --ci/
labels to run additional/fewer testsUPGRADE.md
? --