Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e): simplify localityaware tests #11649

Merged
merged 2 commits into from
Oct 3, 2024
Merged

Conversation

lahabana
Copy link
Contributor

@lahabana lahabana commented Oct 3, 2024

  • remove the complex test nesting
  • write the test as table test
  • use existing helper methods and objects
  • rebalance some tests across jobs

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

- remove the complex test nesting
- write the test as table test
- use existing helper methods and objects
- rebalance some tests across jobs

Signed-off-by: Charly Molter <charly.molter@konghq.com>
@lahabana lahabana added the ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully) label Oct 3, 2024
@lahabana lahabana requested a review from a team as a code owner October 3, 2024 15:34
@lahabana lahabana requested review from bartsmykla and lobkovilya and removed request for a team October 3, 2024 15:34
@slonka
Copy link
Contributor

slonka commented Oct 3, 2024

/format

@slonka
Copy link
Contributor

slonka commented Oct 3, 2024

Format does not work :|

Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka slonka merged commit 8cc25b2 into kumahq:master Oct 3, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants