Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update golangci-lint to 1.47.0 #4830

Merged
merged 13 commits into from
Aug 20, 2022
Merged

ci: update golangci-lint to 1.47.0 #4830

merged 13 commits into from
Aug 20, 2022

Conversation

michaelbeaumont
Copy link
Contributor

@michaelbeaumont michaelbeaumont commented Aug 15, 2022

At the moment ^1.47.1 and 1.48.0 lead to getting OOM killed so we'll stick with 1.47.0 for now.

Checklist prior to review

  • Link to docs PR or issue --
  • Link to UI issue or PR --
  • Is the issue worked on linked? --
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) --
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Unit Tests --
  • E2E Tests --
  • Manual Universal Tests --
  • Manual Kubernetes Tests --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont force-pushed the ci/golangci-lint branch 6 times, most recently from 3fb5ec3 to f8b3912 Compare August 15, 2022 21:58
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Because `gci.custom-order` wasn't respected yet
the kuma vs kuma-net order is incorrect until `1.48.0`.

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont changed the title ci: update golangci-lint to 1.48.0 ci: update golangci-lint to 1.47.0 Aug 15, 2022
@michaelbeaumont michaelbeaumont marked this pull request as ready for review August 15, 2022 22:41
@michaelbeaumont michaelbeaumont requested a review from a team as a code owner August 15, 2022 22:41
@codecov-commenter
Copy link

codecov-commenter commented Aug 15, 2022

Codecov Report

Merging #4830 (69a85f1) into master (7d4c440) will increase coverage by 0.00%.
The diff coverage is 51.61%.

@@           Coverage Diff           @@
##           master    #4830   +/-   ##
=======================================
  Coverage   46.43%   46.44%           
=======================================
  Files         690      690           
  Lines       47141    47141           
=======================================
+ Hits        21891    21893    +2     
  Misses      23330    23330           
+ Partials     1920     1918    -2     
Impacted Files Coverage Δ
app/cni/pkg/cni/injector_linux.go 0.00% <ø> (ø)
app/kuma-dp/pkg/dataplane/metrics/server.go 9.52% <0.00%> (-0.24%) ⬇️
...p/kumactl/cmd/install/install_transparent_proxy.go 82.66% <ø> (ø)
pkg/config/display.go 0.00% <0.00%> (ø)
...ore/resources/apis/mesh/gateway_route_validator.go 96.17% <ø> (ø)
pkg/envoy/admin/client.go 0.00% <0.00%> (ø)
...ns/runtime/k8s/controllers/cni_taint_controller.go 0.00% <0.00%> (ø)
pkg/xds/envoy/listeners/v3/dns_configurer.go 94.33% <ø> (ø)
pkg/xds/sync/dataplane_watchdog.go 0.00% <0.00%> (ø)
app/cni/pkg/install/main.go 6.99% <50.00%> (ø)
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@slonka slonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a bunch of questions :)

.golangci.yml Show resolved Hide resolved
app/kuma-dp/pkg/dataplane/metrics/server.go Outdated Show resolved Hide resolved
pkg/api-server/inspect_endpoints_test.go Show resolved Hide resolved
pkg/test/xds/secrets.go Show resolved Hide resolved
pkg/test/xds/secrets.go Show resolved Hide resolved
test/e2e_env/universal/mtls/mtls.go Show resolved Hide resolved
test/e2e_env/universal/mtls/mtls.go Show resolved Hide resolved
tools/resource-gen/genutils/util.go Show resolved Hide resolved
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
This reverts commit 81bd98c.

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont merged commit 67c3ef3 into master Aug 20, 2022
@michaelbeaumont michaelbeaumont deleted the ci/golangci-lint branch August 20, 2022 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants