Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kuma-cp): multiple external services pointing to same address #5185

Merged
merged 7 commits into from
Oct 24, 2022
Merged

fix(kuma-cp): multiple external services pointing to same address #5185

merged 7 commits into from
Oct 24, 2022

Conversation

slonka
Copy link
Contributor

@slonka slonka commented Oct 20, 2022 •
edited
Loading

Checklist prior to review

closes #4824

  • Link to docs PR or issue -- will add when naming is approved
  • Link to UI issue or PR -- not a UI issue
  • Is the issue worked on linked? -- yes
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) --
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Unit Tests --
  • E2E Tests -- it's just a one config var, not sure we need one
  • Manual Universal Tests --
  • Manual Kubernetes Tests --
  • Do you need to update UPGRADE.md? -- no
  • Does it need to be backported according to the backporting policy? -- no
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests? no

@slonka
feat(kumacp): works unstable
f3171c8 
Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka
feat(kumacp): make test stable
e50bb70 
Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka
feat(kumacp): make check pass
0b3e73e 
Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka
Merge branch 'master' into fix/multiple-external-services-pointing-to…
1e9cf95 
…-same-address
@slonka slonka marked this pull request as ready for review October 21, 2022 07:23
@slonka slonka requested a review from a team as a code owner October 21, 2022 07:23
lahabana
lahabana approved these changes Oct 21, 2022
View reviewed changes
Copy link
Contributor

@lahabana lahabana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A naming question and some nits otherwise LGTM!

api/mesh/v1alpha1/externalservice.proto Outdated Show resolved Hide resolved
pkg/dns/vips/virtual_outbound_view.go Outdated Show resolved Hide resolved
pkg/dns/vips/virtual_outbound_view.go Show resolved Hide resolved
pkg/dns/vips_allocator_test.go Outdated Show resolved Hide resolved
@slonka
feat(kumacp): apply review comments
895d6f7 
Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka
feat(kumacp): make tests pass
10017d6 
Signed-off-by: slonka <slonka@users.noreply.github.com>
lahabana
lahabana reviewed Oct 24, 2022
View reviewed changes
api/mesh/v1alpha1/externalservice.proto Outdated Show resolved Hide resolved
pkg/dns/vips/virtual_outbound_view.go Outdated Show resolved Hide resolved
pkg/dns/vips_allocator_test.go Show resolved Hide resolved
@slonka
feat(kumacp): add test cases
bd2f7f4 
Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka slonka merged commit 5d04362 into kumahq:master Oct 24, 2022
@slonka slonka deleted the fix/multiple-external-services-pointing-to-same-address branch October 24, 2022 11:25
@lukidzi lukidzi changed the title fix(kumacp): multiple external services pointing to same address fix(kuma-cp): multiple external services pointing to same address Nov 3, 2022
@lahabana lahabana mentioned this pull request Dec 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahabana lahabana lahabana approved these changes

@michaelbeaumont michaelbeaumont michaelbeaumont left review comments

@lobkovilya lobkovilya lobkovilya left review comments

@jakubdyszkiewicz jakubdyszkiewicz jakubdyszkiewicz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ExternalServices pointing to same address:port prevents config to be pushed out to Envoy
5 participants
@slonka @lahabana @michaelbeaumont @jakubdyszkiewicz @lobkovilya