Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: validation error path merging with index/keys #5652

Merged
merged 3 commits into from
Jan 11, 2023
Merged

chore: validation error path merging with index/keys #5652

merged 3 commits into from
Jan 11, 2023

Conversation

michaelbeaumont
Copy link
Contributor

@michaelbeaumont michaelbeaumont commented Jan 11, 2023 •
edited
Loading

See the test before and after, without this fix there is a spurious second . in spec.fields.[2].

Checklist prior to review

  • Link to docs PR or issue --
  • Link to UI issue or PR --
  • Is the issue worked on linked? --
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) --
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Unit Tests --
  • E2E Tests --
  • Manual Universal Tests --
  • Manual Kubernetes Tests --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

@michaelbeaumont
test(pkg/core/validators): add index/key test
7a8dd51 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont
fix: validation error merging with index/keys
7033990 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont requested review from a team, bartsmykla, lobkovilya and jakubdyszkiewicz and removed request for a team January 11, 2023 13:24
@michaelbeaumont michaelbeaumont mentioned this pull request Jan 11, 2023
Merged
12 tasks
@michaelbeaumont michaelbeaumont changed the title chore: validation error merging with index/keys chore: validation error path merging with index/keys Jan 11, 2023
@michaelbeaumont michaelbeaumont enabled auto-merge (squash) January 11, 2023 14:17
@michaelbeaumont
refactor(pkg/core/validators): add Concat function, use in AddErrorAt
a0d000f 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont merged commit e6552b6 into kumahq:master Jan 11, 2023
@michaelbeaumont michaelbeaumont deleted the fix/validation_err_merge branch January 11, 2023 17:32
bartsmykla pushed a commit to bartsmykla/kuma that referenced this pull request Jan 14, 2023
@michaelbeaumont @bartsmykla
chore: validation error path merging with index/keys (kumahq#5652)
67687c9 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: Bart Smykla <bartek@smykla.com>
@shaneutt shaneutt mentioned this pull request Feb 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahabana lahabana lahabana approved these changes

@bartsmykla bartsmykla bartsmykla approved these changes

@lobkovilya lobkovilya Awaiting requested review from lobkovilya

@jakubdyszkiewicz jakubdyszkiewicz Awaiting requested review from jakubdyszkiewicz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michaelbeaumont @lahabana @bartsmykla