Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(kuma-cp): switch to kube outbounds as vips by default #5825

Merged
merged 1 commit into from
Jan 25, 2023
Merged

feat(kuma-cp): switch to kube outbounds as vips by default #5825

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/config/app/kuma-cp/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ var DefaultConfig = func() Config {
Access: access.DefaultAccessConfig(),
Experimental: ExperimentalConfig{
GatewayAPI: false,
KubeOutboundsAsVIPs: false,
KubeOutboundsAsVIPs: true,
},
Proxy: xds.DefaultProxyConfig(),
InterCp: intercp.DefaultInterCpConfig(),
Expand Down
2 changes: 1 addition & 1 deletion pkg/config/app/kuma-cp/kuma-cp.defaults.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -564,7 +564,7 @@ experimental:
gatewayAPI: false # ENV: KUMA_EXPERIMENTAL_GATEWAY_API
# If true, instead of embedding kubernetes outbounds into Dataplane object, they are persisted next to VIPs in ConfigMap
# This can improve performance, but it should be enabled only after all instances are migrated to version that supports this config
kubeOutboundsAsVIPs: false # ENV: KUMA_EXPERIMENTAL_KUBE_OUTBOUNDS_AS_VIPS
kubeOutboundsAsVIPs: true # ENV: KUMA_EXPERIMENTAL_KUBE_OUTBOUNDS_AS_VIPS

proxy:
gateway:
Expand Down
6 changes: 3 additions & 3 deletions pkg/config/loader_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,7 @@ var _ = Describe("Config loader", func() {
Expect(cfg.Access.Static.ViewClusters.Groups).To(Equal([]string{"zt-group1", "zt-group2"}))

Expect(cfg.Experimental.GatewayAPI).To(BeTrue())
Expect(cfg.Experimental.KubeOutboundsAsVIPs).To(BeTrue())
Expect(cfg.Experimental.KubeOutboundsAsVIPs).To(BeFalse())

Expect(cfg.Proxy.Gateway.GlobalDownstreamMaxConnections).To(BeNumerically("==", 1))
},
Expand Down Expand Up @@ -584,7 +584,7 @@ access:
groups: ["zt-group1", "zt-group2"]
experimental:
gatewayAPI: true
kubeOutboundsAsVIPs: true
kubeOutboundsAsVIPs: false
cniApp: "kuma-cni"
proxy:
gateway:
Expand Down Expand Up @@ -791,7 +791,7 @@ proxy:
"KUMA_ACCESS_STATIC_VIEW_CLUSTERS_USERS": "zt-admin1,zt-admin2",
"KUMA_ACCESS_STATIC_VIEW_CLUSTERS_GROUPS": "zt-group1,zt-group2",
"KUMA_EXPERIMENTAL_GATEWAY_API": "true",
"KUMA_EXPERIMENTAL_KUBE_OUTBOUNDS_AS_VIPS": "true",
"KUMA_EXPERIMENTAL_KUBE_OUTBOUNDS_AS_VIPS": "false",
"KUMA_PROXY_GATEWAY_GLOBAL_DOWNSTREAM_MAX_CONNECTIONS": "1",
},
yamlFileConfig: "",
Expand Down