Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix docker.sh script #6005

Merged
merged 1 commit into from
Feb 13, 2023
Merged

chore: fix docker.sh script #6005

merged 1 commit into from
Feb 13, 2023

Conversation

jakubdyszkiewicz
Copy link
Contributor

I adjusted distros.sh but not docker.sh. It's only checked during the release. Very unfortunate that it's not part of the CI.

Checklist prior to review

  • Link to docs PR or issue --
  • Link to UI issue or PR --
  • Is the issue worked on linked? --
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) --
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Unit Tests --
  • E2E Tests --
  • Manual Universal Tests --
  • Manual Kubernetes Tests --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

@jakubdyszkiewicz
chore: fix docker.sh script
d691070 
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@jakubdyszkiewicz jakubdyszkiewicz requested a review from a team as a code owner February 13, 2023 17:24
@jakubdyszkiewicz
Copy link
Contributor Author

@Mergifyio backport release-1.8 release-1.7 release-1.6 release-1.5

@jakubdyszkiewicz jakubdyszkiewicz added ci/skip-test PR: Don't run unit and e2e tests (maybe this is just a doc change) ci/skip-e2e-test PR: Don't run e2e tests labels Feb 13, 2023
@mergify
Copy link
Contributor

mergify bot commented Feb 13, 2023 •
edited
Loading

backport release-1.8 release-1.7 release-1.6 release-1.5

✅ Backports have been created

@jakubdyszkiewicz
Copy link
Contributor Author

not waiting for CI since it's not checked on CI anyways.

@jakubdyszkiewicz jakubdyszkiewicz merged commit ddb0e0f into kumahq:release-2.0 Feb 13, 2023
@jakubdyszkiewicz jakubdyszkiewicz deleted the fix-docker-script branch February 13, 2023 17:27
mergify bot pushed a commit that referenced this pull request Feb 13, 2023
@jakubdyszkiewicz @mergify
chore: fix docker.sh script (#6005)
b60adcd 
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
(cherry picked from commit ddb0e0f)

# Conflicts:
#	tools/releases/docker.sh
This was referenced Feb 13, 2023
Merged
Merged
mergify bot pushed a commit that referenced this pull request Feb 13, 2023
@jakubdyszkiewicz @mergify
chore: fix docker.sh script (#6005)
244f2b4 
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
(cherry picked from commit ddb0e0f)

# Conflicts:
#	tools/releases/docker.sh
@mergify mergify bot mentioned this pull request Feb 13, 2023
Merged
mergify bot pushed a commit that referenced this pull request Feb 13, 2023
@jakubdyszkiewicz @mergify
chore: fix docker.sh script (#6005)
af69970 
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
(cherry picked from commit ddb0e0f)

# Conflicts:
#	tools/releases/docker.sh
mergify bot pushed a commit that referenced this pull request Feb 13, 2023
@jakubdyszkiewicz @mergify
chore: fix docker.sh script (#6005)
c088ac2 
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
(cherry picked from commit ddb0e0f)

# Conflicts:
#	tools/releases/docker.sh
@mergify mergify bot mentioned this pull request Feb 13, 2023
Merged
jakubdyszkiewicz added a commit that referenced this pull request Feb 13, 2023
@jakubdyszkiewicz
chore: fix docker.sh script (#6005)
e1e572a 
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
jakubdyszkiewicz added a commit that referenced this pull request Feb 13, 2023
@mergify @jakubdyszkiewicz
chore: fix docker.sh script (backport #6005) (#6006)
760b059 
chore: fix docker.sh script (#6005)

Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Co-authored-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
jakubdyszkiewicz added a commit that referenced this pull request Feb 13, 2023
@jakubdyszkiewicz
chore: fix docker.sh script (#6005)
67a479d 
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
jakubdyszkiewicz added a commit that referenced this pull request Feb 13, 2023
@mergify @jakubdyszkiewicz
chore: fix docker.sh script (backport #6005) (#6007)
77fec72 
chore: fix docker.sh script (#6005)

Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Co-authored-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
jakubdyszkiewicz added a commit that referenced this pull request Feb 13, 2023
@jakubdyszkiewicz
chore: fix docker.sh script (#6005)
b1aa4d3 
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
jakubdyszkiewicz added a commit that referenced this pull request Feb 13, 2023
@mergify @jakubdyszkiewicz
chore: fix docker.sh script (backport #6005) (#6008)
cd321e9 
chore: fix docker.sh script (#6005)

Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Co-authored-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
jakubdyszkiewicz added a commit that referenced this pull request Feb 13, 2023
@jakubdyszkiewicz
chore: fix docker.sh script (#6005)
62cf6c1 
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
jakubdyszkiewicz added a commit that referenced this pull request Feb 13, 2023
@mergify @jakubdyszkiewicz
chore: fix docker.sh script (backport #6005) (#6009)
704a54b 
chore: fix docker.sh script (#6005)

Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Co-authored-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
This was referenced Feb 15, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahabana lahabana lahabana approved these changes

Assignees
No one assigned
Labels
ci/skip-e2e-test PR: Don't run e2e tests ci/skip-test PR: Don't run unit and e2e tests (maybe this is just a doc change)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakubdyszkiewicz @lahabana