-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(helm): add support for controlplane deployment annotations #7959
Merged
michaelbeaumont
merged 2 commits into
kumahq:master
from
slavogiez:feat/helm-cp-deployment-annotations
Oct 13, 2023
Merged
feat(helm): add support for controlplane deployment annotations #7959
michaelbeaumont
merged 2 commits into
kumahq:master
from
slavogiez:feat/helm-cp-deployment-annotations
Oct 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slavogiez
force-pushed
the
feat/helm-cp-deployment-annotations
branch
4 times, most recently
from
October 4, 2023 12:48
854bcd7
to
7f1463a
Compare
slavogiez
force-pushed
the
feat/helm-cp-deployment-annotations
branch
3 times, most recently
from
October 6, 2023 06:53
6b4f120
to
bcd6841
Compare
app/kumactl/cmd/install/testdata/install-control-plane.dump-values.yaml
Outdated
Show resolved
Hide resolved
slavogiez
requested review from
Automaat and
bartsmykla
and removed request for
a team
October 6, 2023 07:29
slavogiez
force-pushed
the
feat/helm-cp-deployment-annotations
branch
2 times, most recently
from
October 6, 2023 09:00
e000dea
to
e17e37a
Compare
/format /golden_files |
Co-authored-by: Mike Beaumont <mjboamail@gmail.com> Signed-off-by: slavogiez <stephane.lavogiez@gmail.com>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
slavogiez
force-pushed
the
feat/helm-cp-deployment-annotations
branch
from
October 9, 2023 06:38
d775474
to
89dc5db
Compare
michaelbeaumont
approved these changes
Oct 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
@slavogiez is it ok if we mark this ready as review and merge? Or was there something you wanted to add/change? |
Everything's ok. LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds ability to add annotations on the controlplane deployment.
Not sure if it's the best way to do this. Please also let me know if you'd like to get the same feature on other deployments (ingress, egress, ...)
Checklist prior to review
syscall.Mkfifo
have equivalent implementation on the other OS --UPGRADE.md
? --> Changelog:
entry here or add aci/
label to run fewer/more tests?