Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helm): add loadBalancerSourceRanges on global zone sync service #7978

Merged
merged 2 commits into from
Oct 16, 2023

Conversation

slavogiez
Copy link
Contributor

@slavogiez slavogiez commented Oct 9, 2023

This adds support for loadBalancerSourceRanges on Global zone sync service load balancer.

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

Signed-off-by: slavogiez <stephane.lavogiez@gmail.com>
@slavogiez slavogiez marked this pull request as ready for review October 13, 2023 06:59
@slavogiez slavogiez requested a review from a team as a code owner October 13, 2023 06:59
@slavogiez slavogiez requested review from slonka and bartsmykla and removed request for a team October 13, 2023 06:59
@slavogiez
Copy link
Contributor Author

Not sure what I should do to fix the kumma-commit check. Can you help me? :)

Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka
Copy link
Contributor

slonka commented Oct 13, 2023

I pushed a commit to make check pass. Hope you don't mind. If you do, I won't do this next time.

@slonka slonka merged commit 27cc6d0 into kumahq:master Oct 16, 2023
5 checks passed
@slavogiez
Copy link
Contributor Author

I pushed a commit to make check pass. Hope you don't mind. If you do, I won't do this next time.

No problem, thanks for your help :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants