Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api-server): add /-overview for all types that have overviews #7999

Merged
merged 5 commits into from
Oct 16, 2023

Conversation

lahabana
Copy link
Contributor

@lahabana lahabana commented Oct 10, 2023

There used to be some incoherency with overview endpoints they were also all reimplemented from scratch and would need us to reimplement filtering etc each time.

We now leverage our code generation to indicate which type have a overview we do all this with backward compatibility on the api

Fix #3336

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

Changelog: feat(api-server): add /_overview for all types that have overviews

There used to be some incoherency with overview endpoints they were also
all reimplemented from scratch and would need us to reimplement
filtering etc each time.

We now leverage our code generation to indicate which type have a
`overview` we do all this with backward compatibility on the api

Fix kumahq#3336

Signed-off-by: Charly Molter <charly.molter@konghq.com>
Signed-off-by: Charly Molter <charly.molter@konghq.com>
pkg/core/resources/model/resource.go Outdated Show resolved Hide resolved
pkg/core/resources/model/resource.go Outdated Show resolved Hide resolved
pkg/api-server/resource_endpoints.go Show resolved Hide resolved
lahabana and others added 2 commits October 16, 2023 13:27
Co-authored-by: Bart Smykla <bartek@smykla.com>
Signed-off-by: Charly Molter <charly@molter.io>
@lahabana lahabana enabled auto-merge (squash) October 16, 2023 11:32
@lahabana lahabana merged commit 85541e4 into kumahq:master Oct 16, 2023
5 checks passed
@lahabana lahabana deleted the fix3336 branch March 29, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Normalise apis for insights and overview
2 participants