Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(security): filter out kuma from security update #8098

Merged
merged 1 commit into from
Oct 23, 2023
Merged

ci(security): filter out kuma from security update #8098

merged 1 commit into from
Oct 23, 2023

Conversation

slonka
Copy link
Contributor

@slonka slonka commented Oct 23, 2023 •
edited
Loading

since the publishing of our CVE advisory in Kuma and it being picked up by osv scanner https://osv.dev/vulnerability/GHSA-9wmc-rg4h-28wv our security update action is failing in parent project (it's trying to update to 2.0.8 per our policy of upgrading deps to the lowest one that is patched).

This PR simply filters out kuma from that job.

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues -- not reported via issue
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) -- yes

@slonka
ci(security): filter out kuma from security update
3759ca4 
Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka slonka added the ci/skip-test PR: Don't run unit and e2e tests (maybe this is just a doc change) label Oct 23, 2023
@slonka slonka requested a review from a team as a code owner October 23, 2023 06:55
@slonka slonka requested review from lobkovilya and lukidzi and removed request for a team October 23, 2023 06:55
@slonka slonka removed the backport label Oct 23, 2023
@slonka slonka merged commit c7295a9 into kumahq:master Oct 23, 2023
18 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2023 •
edited
Loading

backporting to release-2.1 with action

backporting to release-2.3 with action
backporting to release-2.2 with action
backporting to release-2.4 with action

@github-actions
Copy link
Contributor

backporting to release-2.0 with action

kumahq bot pushed a commit that referenced this pull request Oct 23, 2023
@slonka @kumahq
ci(security): filter out kuma from security update (#8098)
0135a99 
Signed-off-by: slonka <slonka@users.noreply.github.com>
This was referenced Oct 23, 2023
Merged
Merged
Merged
kumahq bot pushed a commit that referenced this pull request Oct 23, 2023
@slonka @kumahq
ci(security): filter out kuma from security update (#8098)
553640a 
Signed-off-by: slonka <slonka@users.noreply.github.com>
kumahq bot pushed a commit that referenced this pull request Oct 23, 2023
@slonka @kumahq
ci(security): filter out kuma from security update (#8098)
19c6d74 
Signed-off-by: slonka <slonka@users.noreply.github.com>
kumahq bot pushed a commit that referenced this pull request Oct 23, 2023
@slonka @kumahq
ci(security): filter out kuma from security update (#8098)
5115755 
Signed-off-by: slonka <slonka@users.noreply.github.com>
This was referenced Oct 23, 2023
Merged
Merged
kumahq bot pushed a commit that referenced this pull request Oct 23, 2023
@slonka @kumahq
ci(security): filter out kuma from security update (#8098)
3d17290 
Signed-off-by: slonka <slonka@users.noreply.github.com>
slonka added a commit that referenced this pull request Oct 23, 2023
@kumahq @slonka
ci(security): filter out kuma from security update (backport of #8098) (
d1486ad 
#8103)

ci(security): filter out kuma from security update (#8098)

Signed-off-by: slonka <slonka@users.noreply.github.com>
Co-authored-by: Krzysztof Słonka <slonka@users.noreply.github.com>
slonka added a commit that referenced this pull request Oct 23, 2023
@kumahq @slonka
ci(security): filter out kuma from security update (backport of #8098) (
3851164 
#8102)

ci(security): filter out kuma from security update (#8098)

Signed-off-by: slonka <slonka@users.noreply.github.com>
Co-authored-by: Krzysztof Słonka <slonka@users.noreply.github.com>
slonka added a commit that referenced this pull request Oct 23, 2023
@kumahq @slonka
ci(security): filter out kuma from security update (backport of #8098) (
c693ad5 
#8101)

ci(security): filter out kuma from security update (#8098)

Signed-off-by: slonka <slonka@users.noreply.github.com>
Co-authored-by: Krzysztof Słonka <slonka@users.noreply.github.com>
slonka added a commit that referenced this pull request Oct 23, 2023
@kumahq @slonka
ci(security): filter out kuma from security update (backport of #8098) (
e65aa46 
#8100)

ci(security): filter out kuma from security update (#8098)

Signed-off-by: slonka <slonka@users.noreply.github.com>
Co-authored-by: Krzysztof Słonka <slonka@users.noreply.github.com>
slonka added a commit that referenced this pull request Oct 23, 2023
@kumahq @slonka
ci(security): filter out kuma from security update (backport of #8098) (
6d706e5 
#8099)

ci(security): filter out kuma from security update (#8098)

Signed-off-by: slonka <slonka@users.noreply.github.com>
Co-authored-by: Krzysztof Słonka <slonka@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartsmykla bartsmykla bartsmykla approved these changes

@lobkovilya lobkovilya Awaiting requested review from lobkovilya lobkovilya is a code owner automatically assigned from kumahq/kuma-maintainers

@lukidzi lukidzi Awaiting requested review from lukidzi lukidzi is a code owner automatically assigned from kumahq/kuma-maintainers

Assignees
No one assigned
Labels
backport ci/skip-test PR: Don't run unit and e2e tests (maybe this is just a doc change)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slonka @bartsmykla