Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kuma-cp): using policy name with "." causes hash to be inserted in the wrong place on the zone #8240

Merged

Conversation

lobkovilya
Copy link
Contributor

@lobkovilya lobkovilya commented Nov 2, 2023

Since we allow a dot in the policy name, we can't use functions like CoreNameToK8sName that try to parse the name and make assumptions based on .<namespace> suffix.

Checklist prior to review

…tion

Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lahabana
Copy link
Contributor

lahabana commented Nov 2, 2023

Ok I'm completely confused with names. Can we have a doc that describes what happens to names between global and zones in all cases (global k8s, global universal, zone k8s, zone universal) ?

@lobkovilya
Copy link
Contributor Author

Sure, do you think it should be a kuma-website doc or a more developer-oriented doc in this repo?

Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya
Copy link
Contributor Author

@lahabana I pushed the doc under the docs/guides for now, please check if it makes sense to you

@lobkovilya lobkovilya marked this pull request as ready for review November 3, 2023 12:19
@lobkovilya lobkovilya requested a review from a team as a code owner November 3, 2023 12:19
@lobkovilya lobkovilya requested review from Automaat and lukidzi and removed request for a team November 3, 2023 12:19
@lobkovilya lobkovilya changed the base branch from master to release-2.5 November 6, 2023 09:25
@lobkovilya lobkovilya merged commit 4793fde into kumahq:release-2.5 Nov 8, 2023
5 checks passed
@lobkovilya lobkovilya deleted the fix/hash-suffix-regardless-ns branch November 8, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using policy name with "." causes hash to be inserted in the wrong place on the zone
3 participants