Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(observability): add annotation to make observability while running CNI work #8330

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

slonka
Copy link
Contributor

@slonka slonka commented Nov 13, 2023

without this we get "bad address: github.com" errors

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues -- xrel: Kuma-metrics Grafana init-plugins container error  #4448
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

…g CNI work

Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka slonka added the ci/skip-e2e-test PR: Don't run e2e tests label Nov 13, 2023
@slonka slonka requested a review from a team as a code owner November 13, 2023 14:26
@slonka slonka requested review from jakubdyszkiewicz and bartsmykla and removed request for a team November 13, 2023 14:26
@slonka
Copy link
Contributor Author

slonka commented Nov 13, 2023

/golden_files

@slonka slonka requested a review from lahabana November 13, 2023 16:05
@bartsmykla bartsmykla merged commit c5e8707 into kumahq:release-2.5 Nov 14, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/skip-e2e-test PR: Don't run e2e tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants