Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(transparent-proxy): fix --wait flags for iptables legacy #8364

Merged
merged 1 commit into from
Nov 14, 2023
Merged

fix(transparent-proxy): fix --wait flags for iptables legacy #8364

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/transparentproxy/iptables/parameters/wait.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ func Wait(seconds uint) *Parameter {

return &Parameter{
long: "--wait",
short: "-w",
short: "--wait",
connector: "=",
parameters: []ParameterBuilder{&WaitParameter{seconds: seconds}},
negate: nil, // no negation allowed
Expand Down
2 changes: 1 addition & 1 deletion pkg/transparentproxy/iptables/parameters/wait_interval.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ func WaitInterval(microseconds uint) *Parameter {

return &Parameter{
long: "--wait-interval",
short: "-W",
short: "--wait-interval",
connector: "=",
parameters: []ParameterBuilder{
&WaitIntervalParameter{microseconds: microseconds},
Expand Down
2 changes: 1 addition & 1 deletion pkg/transparentproxy/iptables/parameters/wait_interval_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ var _ = Describe("WaitIntervalParameter", func() {
},
Entry("no flag when parameter is 0", 0, false, ""),
Entry("no flag when parameter is 0 - verbose", 0, true, ""),
Entry("wait interval", 20, false, "-W=20"),
Entry("wait interval", 20, false, "--wait-interval=20"),
Entry("wait interval - verbose", 20, true, "--wait-interval=20"),
)
})
2 changes: 1 addition & 1 deletion pkg/transparentproxy/iptables/parameters/wait_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ var _ = Describe("WaitParameter", func() {
},
Entry("no flag when parameter is 0", 0, false, ""),
Entry("no flag when parameter is 0 - verbose", 0, true, ""),
Entry("wait seconds", 10, false, "-w=10"),
Entry("wait seconds", 10, false, "--wait=10"),
Entry("wait seconds - verbose", 10, true, "--wait=10"),
)
})
Loading