ci(e2e): upload junit results to gh artifacts #9354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bart Smykla <bartek@smykla.com>
bartsmykla
requested review from
jakubdyszkiewicz and
Automaat
and removed request for
a team
slonka
approved these changes
Feb 22, 2024
|
Now it works: https://github.com/kumahq/kuma/actions/runs/8010206149?pr=9354 |
slonka
reviewed
Feb 22, 2024
Signed-off-by: slonka <slonka@users.noreply.github.com>
slonka
reviewed
Feb 22, 2024
Signed-off-by: Bart Smykla <bartek@smykla.com>
slonka
reviewed
Feb 23, 2024
Co-authored-by: Krzysztof Słonka <slonka@users.noreply.github.com> Signed-off-by: Bart Smykla <bartek@smykla.com>
lahabana
reviewed
Feb 23, 2024
| @@ -21,6 +21,7 @@ env: | |||
| E2E_PARAM_TARGET: ${{ fromJSON(inputs.matrix).target }} | |||
| E2E_PARAM_PARALLELISM: ${{ fromJSON(inputs.matrix).parallelism }} | |||
| CI_TOOLS_DIR: /home/runner/work/kuma/kuma/.ci_tools | |||
| E2E_RUN_NAME: ${{ fromJSON(inputs.matrix).target }}_${{ fromJSON(inputs.matrix).k8sVersion }}_${{ fromJSON(inputs.matrix).cniNetworkPlugin }}_${{ fromJSON(inputs.matrix).arch }}_${{ fromJSON(inputs.matrix).parallelism }} | |||
There was a problem hiding this comment.
Hmm this is not very future proof with actions in km. There's likely something better with inputs, the context or something like this no?
lahabana
reviewed
Feb 23, 2024
| name: test_e2e_${{ env.E2E_RUN_NAME }}-${{ (github.event.pull_request.head.sha||github.sha) }}-${{ github.run_id }} | ||
| path: | | ||
| build/reports/results.xml | ||
| build/reports/results.json |
There was a problem hiding this comment.
This is likely going to fail on run-type == 'circleci' no?
bartsmykla
added a commit
to bartsmykla/kuma
that referenced
this pull request
Feb 23, 2024
This reverts commit d94a686.
bartsmykla
added a commit
to bartsmykla/kuma
that referenced
this pull request
Feb 23, 2024
This reverts commit d94a686. Signed-off-by: Bart Smykla <bartek@smykla.com>
bartsmykla
added a commit
that referenced
this pull request
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist prior to review
syscall.Mkfifohave equivalent implementation on the other OS --ci/labels to run additional/fewer testsUPGRADE.md? --