Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(MADR): mesh service multizone ux #9979

Merged

Conversation

jakubdyszkiewicz
Copy link
Contributor

Checklist prior to review

Ready for review. Once referenced MADR are merged, I'll update this MADR with specific references.

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@jakubdyszkiewicz jakubdyszkiewicz requested a review from a team as a code owner April 18, 2024 10:28
@jakubdyszkiewicz jakubdyszkiewicz requested review from jijiechen, bartsmykla and lukidzi and removed request for a team April 18, 2024 10:28
@jakubdyszkiewicz jakubdyszkiewicz added the ci/skip-test PR: Don't run unit and e2e tests (maybe this is just a doc change) label Apr 18, 2024
docs/madr/decisions/046-meshservice-multizone.md Outdated Show resolved Hide resolved
docs/madr/decisions/046-meshservice-multizone.md Outdated Show resolved Hide resolved
docs/madr/decisions/046-meshservice-multizone.md Outdated Show resolved Hide resolved
docs/madr/decisions/046-meshservice-multizone.md Outdated Show resolved Hide resolved
docs/madr/decisions/046-meshservice-multizone.md Outdated Show resolved Hide resolved
Co-authored-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
docs/madr/decisions/046-meshservice-multizone.md Outdated Show resolved Hide resolved
docs/madr/decisions/046-meshservice-multizone.md Outdated Show resolved Hide resolved
docs/madr/decisions/046-meshservice-multizone.md Outdated Show resolved Hide resolved
docs/madr/decisions/046-meshservice-multizone.md Outdated Show resolved Hide resolved
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Copy link
Contributor

@lahabana lahabana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some minor comments but preemptively approving this

Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Copy link
Contributor

@lahabana lahabana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor questions but still LGTM

docs/madr/decisions/046-meshservice-multizone.md Outdated Show resolved Hide resolved
docs/madr/decisions/046-meshservice-multizone.md Outdated Show resolved Hide resolved
docs/madr/decisions/046-meshservice-multizone.md Outdated Show resolved Hide resolved
docs/madr/decisions/046-meshservice-multizone.md Outdated Show resolved Hide resolved
docs/madr/decisions/046-meshservice-multizone.md Outdated Show resolved Hide resolved
docs/madr/decisions/046-meshservice-multizone.md Outdated Show resolved Hide resolved
docs/madr/decisions/046-meshservice-multizone.md Outdated Show resolved Hide resolved
docs/madr/decisions/046-meshservice-multizone.md Outdated Show resolved Hide resolved
docs/madr/decisions/046-meshservice-multizone.md Outdated Show resolved Hide resolved
docs/madr/decisions/046-meshservice-multizone.md Outdated Show resolved Hide resolved
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
…izone

Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@jakubdyszkiewicz jakubdyszkiewicz enabled auto-merge (squash) May 14, 2024 08:09
@jakubdyszkiewicz jakubdyszkiewicz merged commit 0b43c08 into kumahq:master May 14, 2024
11 checks passed
@jakubdyszkiewicz jakubdyszkiewicz deleted the feat/madr-ms-multizone branch May 14, 2024 08:17
@michaelbeaumont michaelbeaumont mentioned this pull request Jun 17, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/skip-test PR: Don't run unit and e2e tests (maybe this is just a doc change)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants