-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(MADR): mesh service multizone ux #9979
Merged
jakubdyszkiewicz
merged 7 commits into
kumahq:master
from
jakubdyszkiewicz:feat/madr-ms-multizone
May 14, 2024
Merged
docs(MADR): mesh service multizone ux #9979
jakubdyszkiewicz
merged 7 commits into
kumahq:master
from
jakubdyszkiewicz:feat/madr-ms-multizone
May 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
jakubdyszkiewicz
requested review from
jijiechen,
bartsmykla and
lukidzi
and removed request for
a team
April 18, 2024 10:28
jakubdyszkiewicz
added
the
ci/skip-test
PR: Don't run unit and e2e tests (maybe this is just a doc change)
label
Apr 18, 2024
Co-authored-by: Mike Beaumont <mjboamail@gmail.com> Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
lahabana
reviewed
May 6, 2024
lahabana
reviewed
May 6, 2024
lukidzi
reviewed
May 7, 2024
lukidzi
reviewed
May 7, 2024
lahabana
reviewed
May 10, 2024
lahabana
approved these changes
May 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some minor comments but preemptively approving this
michaelbeaumont
approved these changes
May 10, 2024
lukidzi
approved these changes
May 10, 2024
lahabana
approved these changes
May 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor questions but still LGTM
…izone Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist prior to review
Ready for review. Once referenced MADR are merged, I'll update this MADR with specific references.
syscall.Mkfifo
have equivalent implementation on the other OS --ci/
labels to run additional/fewer testsUPGRADE.md
? --