Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(kuma-cp): remove 'pq' driver support #9983

Merged
merged 4 commits into from
Apr 18, 2024

Conversation

lobkovilya
Copy link
Contributor

@lobkovilya lobkovilya commented Apr 18, 2024

  • we deprecated in 2.6, now we can remove it

  • postgres unit tests take the longest, removing pq tests saves some time

    before:

    github.com/kumahq/kuma/pkg/plugins/resources/postgres	350.466s
    

    after:

    github.com/kumahq/kuma/pkg/plugins/resources/postgres	113.717s
    

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya lobkovilya marked this pull request as ready for review April 18, 2024 14:01
@lobkovilya lobkovilya requested a review from a team as a code owner April 18, 2024 14:01
@lobkovilya lobkovilya requested review from jijiechen, michaelbeaumont and lukidzi and removed request for a team April 18, 2024 14:01
Copy link
Contributor

@jakubdyszkiewicz jakubdyszkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!

@lobkovilya lobkovilya merged commit 6cb2a24 into kumahq:master Apr 18, 2024
16 checks passed
@lobkovilya lobkovilya deleted the remove-pq-driver branch April 18, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants