feature: enable base64 processing #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fajrifernanda
approved these changes
Nov 19, 2024
zhenqianz
reviewed
Nov 19, 2024
| @@ -148,10 +149,6 @@ func (app *Imagor) Shutdown(ctx context.Context) (err error) { | |||
|
|
|||
| // ServeHTTP implements http.Handler for imagor operations | |||
| func (app *Imagor) ServeHTTP(w http.ResponseWriter, r *http.Request) { | |||
| if r.Method != http.MethodGet && r.Method != http.MethodHead { | |||
zhenqianz
reviewed
Nov 19, 2024
imagor.go
Outdated
| } | ||
|
|
||
| jsonField := new(supportedJSONField) | ||
| err = json.NewDecoder(r.Body).Decode(&jsonField) |
There was a problem hiding this comment.
ga perlu ada & lagi soalnya, soalnya udh pointer
zhenqianz
reviewed
Nov 19, 2024
| if !isBlobEmpty(blob) && err == nil { | ||
| return | ||
| } | ||
| } | ||
| for _, loader := range loaders { |
There was a problem hiding this comment.
kalo base64 masuk ke sini juga? imagenya masih ""?
There was a problem hiding this comment.
gw udah coba bikin loader terpisah untuk base64, tapi pas di line ini loader base64 selalu ngga ke-include. padahal pas run di awal tuh udah gw tambahin loadernya. makanya jadinya gini
There was a problem hiding this comment.
aman, gw test yg non base64 juga aman
zhenqianz
reviewed
Nov 19, 2024
zhenqianz
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.