Skip to content

Commit

Permalink
ネットワークインストールの際のエラーを修正 (#72)
Browse files Browse the repository at this point in the history
<!-- This is an auto-generated comment: release notes by OSS CodeRabbit
-->
### Summary by CodeRabbit

- Bug Fix: Improved the network installation process for multisite
setups in version 3.7.1. We've introduced a more precise method
`should_network_activate` to determine whether individual activation
should occur during network installation. This fix enhances the
reliability of the plugin's behavior across different network
configurations.
<!-- end of auto-generated comment: release notes by OSS CodeRabbit -->
  • Loading branch information
fumikito authored Oct 8, 2024
2 parents 6d5fbf2 + cf09c76 commit 841b51c
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
4 changes: 4 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,10 @@ Create a new [issue](https://github.com/kuno1/ga-communicator/issues) or send [p

## Changelog

### 3.7.1

* Fix setting error on individual activation under network install.

### 3.0.0

* Add [Google Analytics Data API](https://developers.google.com/analytics/devguides/reporting/data/v1) support. [Core Reporting API](https://developers.google.com/analytics/devguides/reporting/core/v4?hl=ja) will be deprecated in 2023.
Expand Down
2 changes: 1 addition & 1 deletion src/Kunoichi/GaCommunicator/Screen/Settings.php
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ public function network_admin_menu() {
public function admin_screen() {
wp_enqueue_style( 'ga-communicator-setting' );
wp_enqueue_script( 'ga-communicator-setting' );
if ( is_multisite() ) {
if ( $this->should_network_activate() ) {
$action = add_query_arg( [
'action' => 'update_' . $this->slug,
], network_admin_url( 'edit.php' ) );
Expand Down

0 comments on commit 841b51c

Please sign in to comment.