Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: how to use unified backup #414

Merged
merged 2 commits into from
Oct 28, 2023
Merged

Conversation

Xieql
Copy link
Contributor

@Xieql Xieql commented Oct 25, 2023

What type of PR is this?

/kind documentation

What this PR does / why we need it:

add doc of introduction of unified backup and how to use unified backup

part of #404

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

add doc of introduction of unified backup and how to use unified backup

@netlify
Copy link

netlify bot commented Oct 25, 2023

Deploy Preview for kurator-dev ready!

Name Link
🔨 Latest commit 27f2a63
🔍 Latest deploy log https://app.netlify.com/sites/kurator-dev/deploys/653c83bc7a320c000890b21e
😎 Deploy Preview https://deploy-preview-414--kurator-dev.netlify.app/docs/fleet-manager/backup/backup
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Xieql
Copy link
Contributor Author

Xieql commented Oct 25, 2023

@hzxuzhonghu PTAL


```console
kubectl apply -f examples/backup/busybox.yaml --kubeconfig=/root/.kube/kurator-member1.config
kubectl apply -f examples/backup/busybox.yaml --kubeconfig=/root/.kube/kurator-member2.config
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you use kurator mechanism, application way

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current document is focused on backups. I'm not sure if it's appropriate to include other components here, especially since we might make adjustments to the application content in the CI/CD area.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kurator, we provide an entry for multi clusters. If users can operate each cluster directly, why would they even make trouble to try kurator?

https://kurator.dev/docs/fleet-manager/policy/

Signed-off-by: Xieql <xieqianglong@huawei.com>
@Xieql Xieql force-pushed the doc-unified-bakup branch from 12110c7 to 83c8bff Compare October 28, 2023 03:00
Signed-off-by: Xieql <xieqianglong@huawei.com>
@Xieql Xieql force-pushed the doc-unified-bakup branch from 83c8bff to 27f2a63 Compare October 28, 2023 03:44
Copy link
Member

@hzxuzhonghu hzxuzhonghu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

labels:
app: busybox-with-pv
spec:
automountServiceAccountToken: false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not necessary

app: busybox-with-pv
spec:
automountServiceAccountToken: false
hostIPC: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@kurator-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kurator-bot kurator-bot merged commit 1d5a2a5 into kurator-dev:main Oct 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants