bugfix: make sure ns exsit when create velero secret #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xieql <xieqianglong@huawei.com>
✅ Deploy Preview for kurator-dev canceled.
|
hzxuzhonghu
reviewed
Oct 30, 2023
| @@ -210,9 +212,28 @@ func createNewSecretInFleetCluster(cluster *fleetCluster, newSecret *corev1.Secr | |||
| // Get the namespace of the secret | |||
| namespace := newSecret.Namespace | |||
|
|
|||
| // Check if namespace exists | |||
| _, err := kubeClient.CoreV1().Namespaces().Get(context.TODO(), namespace, metav1.GetOptions{}) | |||
There was a problem hiding this comment.
nit: reuse karmadautil.EnsureNamespaceExist
hzxuzhonghu
approved these changes
Oct 30, 2023
hzxuzhonghu
reviewed
Oct 30, 2023
| return fmt.Errorf("failed to check for namespace %s: %w", namespace, err) | ||
| } | ||
| } | ||
|
|
||
| // Create the new secret | ||
| if _, err := kubeClient.CoreV1().Secrets(namespace).Create(context.TODO(), newSecret, metav1.CreateOptions{}); err != nil && !apierrors.IsAlreadyExists(err) { |
There was a problem hiding this comment.
duplicate creating secret, though you have checked alkready exists
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hzxuzhonghu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
In response to a cherrypick label: new pull request created: #429 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Ensures namespace exists in the target cluster before creating secrets, preventing potential failures.
Adds logic to check for namespace existence and creates it if missing, prior to secret creation.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: