Optimised fleet update function of e2e test #603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kurator-dev canceled.
|
hzxuzhonghu
reviewed
Feb 20, 2024
LiZhenCheng9527
force-pushed
the
update-fleet
branch
from
74598d6 to
b5121e7
Compare
LiZhenCheng9527
force-pushed
the
update-fleet
branch
from
6408143 to
23b7466
Compare
Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
LiZhenCheng9527
force-pushed
the
update-fleet
branch
2 times, most recently
from
19dbb53 to
ee27c83
Compare
Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
LiZhenCheng9527
force-pushed
the
update-fleet
branch
from
ee27c83 to
80aabd1
Compare
Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
LiZhenCheng9527
force-pushed
the
update-fleet
branch
from
2b396a4 to
5de9703
Compare
hzxuzhonghu
reviewed
Feb 27, 2024
e2e/resources/attachedcluster.go
Outdated
| return getErr | ||
| } | ||
| attachedCluster.ResourceVersion = originalAttachedCluster.ResourceVersion | ||
| attachedClusterPatchData, createPatchErr := CreatePatchData(originalAttachedCluster, attachedCluster) |
There was a problem hiding this comment.
Doesn't it remove the labels and status we set
|
This PR has been revised and is ready to be reviewed. |
hzxuzhonghu
reviewed
Mar 4, 2024
| return patchData, nil | ||
| } | ||
|
|
||
| func ModifiedObjectMeta(original, modified metav1.ObjectMeta) metav1.ObjectMeta { |
There was a problem hiding this comment.
we donot need to deepcopy the object meta
Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
LiZhenCheng9527
force-pushed
the
update-fleet
branch
from
d9d39df to
421010a
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hzxuzhonghu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Optimised fleet update function of e2e test
Which issue(s) this PR fixes:
a part of #436