Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinning the Version of license-lint #609

Merged
merged 2 commits into from
Feb 23, 2024

Conversation

LiZhenCheng9527
Copy link
Contributor

What type of PR is this?
/kind bug

What this PR does / why we need it:
The licenses check functionality in the CI system was broken due to an issue where the version of license-lint was upgraded automatically.
By locking down license-lint to a specific, known-good version, the licenses check task is able to perform reliably on each build
Which issue(s) this PR fixes:
Fixes #608

Copy link

netlify bot commented Feb 23, 2024

Deploy Preview for kurator-dev canceled.

Name Link
🔨 Latest commit 7112cba
🔍 Latest deploy log https://app.netlify.com/sites/kurator-dev/deploys/65d84bc346c47100087962fd

Copy link
Member

@hzxuzhonghu hzxuzhonghu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kurator-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
@hzxuzhonghu
Copy link
Member

/lgtm

@kurator-bot kurator-bot merged commit 9866f70 into kurator-dev:main Feb 23, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Licenses Check Failing in Kurator CI Due to Updated istio-tools Version
3 participants