Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix get VERSION command in install Kurator #610

Merged
merged 2 commits into from
Feb 27, 2024

Conversation

LiZhenCheng9527
Copy link
Contributor

@LiZhenCheng9527 LiZhenCheng9527 commented Feb 23, 2024

What type of PR is this?
/kind feature

What this PR does / why we need it:
Fix get VERSION command in install Kurator

Copy link

netlify bot commented Feb 23, 2024

Deploy Preview for kurator-dev canceled.

Name Link
🔨 Latest commit 4d2ca24
🔍 Latest deploy log https://app.netlify.com/sites/kurator-dev/deploys/65dbed48d9b3560008e8ef22

@LiZhenCheng9527 LiZhenCheng9527 force-pushed the helm-check branch 2 times, most recently from 3ec5c91 to a4dea0e Compare February 26, 2024 01:14
@LiZhenCheng9527 LiZhenCheng9527 changed the title add helm install check and fix get VERSION function in install Kurator Fix get VERSION command in install Kurator Feb 26, 2024
Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
Copy link
Member

@hzxuzhonghu hzxuzhonghu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kurator-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kurator-bot kurator-bot merged commit 1251671 into kurator-dev:main Feb 27, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants