Detach attach #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s#9757) * ci(workflow): add 'npm' cache for actions/setup-node in .github/workflows * style(workflows): restore single quotes and remove unnecessary 'null'
* Fix: Typo 'is less' -> 'are lesser' * Update plugin.decimation.js
Inserted a hyperlink on chart.js logo So that users can easily be redirected to the HOME PAGE of the web application
* Fix cleaning up metasets I believe it's a mistake to only delete the metaset if it has a valid controller; see f191f2f for where this behavior was introduced. This is a minimal fix for chartjs#9653; as discussed there, it may also be worth updating `updateHoverStyle`. As of chartjs#7030, `this._metasets` should always be defined, so checking whether it's undefined is no longer necessary. * Add a test covering metaset behavior * Add a regression test for chartjs#9653; fix `toHaveSize` usage * Fix test failure
* make object available for bar as border Radius * override only the bar borderWidth prop * spacing
* Remove scriptability from defaults.font types * Remove failing test
* Define with let to avoid "assignment to constant" errors Thanks for this example. Defining `label` with `const` rather than `let` results in `Uncaught TypeError: Assignment to constant variable.` * Another case where const needs to be replaced with let. * Requested cases where const needs to be replaced with let +1 (style).
* update type of scale position in docs, add explanation sentence to object position * improve clarification * grammar/spelling
* Fix type linting and indent errors * Properly indent comments too
* add autopadding to types * fix failing test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.